minor tweaks

Author: rahulsavani

tests/games.py

@@ -18,7 +18,7 @@ def read_from_file(fn: str) -> gbt.Game:
         raise ValueError(f"Unknown file extension in {fn}")
 
 
-def create_efg_corresponding_to_bimatrix_Game(
+def create_efg_corresponding_to_bimatrix_game(
     A: np.ndarray, B: np.ndarray, title: str
 ) -> gbt.Game:
     """
@@ -601,7 +601,7 @@ def create_EFG_for_nxn_bimatrix_coordination_game(n: int) -> gbt.Game:
     A = np.eye(n, dtype=int)
     B = A
     title = f"{n}x{n} coordination game, {2**n - 1} equilibria"
-    return create_efg_corresponding_to_bimatrix_Game(A, B, title)
+    return create_efg_corresponding_to_bimatrix_game(A, B, title)
 
 
 def create_EFG_for_6x6_bimatrix_with_long_LH_paths_and_unique_eq() -> gbt.Game:
@@ -626,7 +626,7 @@ def create_EFG_for_6x6_bimatrix_with_long_LH_paths_and_unique_eq() -> gbt.Game:
     A = np.array(A)
     B = np.array(B)
     title = "6x6 Long Lemke-Howson Paths, unique eq"
-    return create_efg_corresponding_to_bimatrix_Game(A, B, title)
+    return create_efg_corresponding_to_bimatrix_game(A, B, title)
 
 
 class EfgFamilyForReducedStrategicFormTests(ABC):

tests/test_extensive.py

@@ -377,7 +377,7 @@ def test_outcome_index_exception_label():
     ],
 )
 def test_reduced_strategic_form(
-    game: gbt.Game, strategy_labels: list, np_arrays_of_rsf: list
+    game: gbt.Game, strategy_labels: list, np_arrays_of_rsf: typing.Union[list, None]
 ):
     """
     We test two things:

tests/test_nash.py

@@ -3,7 +3,8 @@
 For many solvers the tests simply ensure that calling the solver works, and then for some cases,
 checking the expected results on a very simple game.
 
-Better test coverage is there for lp_solve, lcp_solve, and enumpoly_solve for behavior strategies.
+There is better test coverage for
+lp_solve, lcp_solve, and enumpoly_solve, all in behavior strategies.
 """
 import typing
 
@@ -28,8 +29,9 @@ def test_enumpure_agent():
     assert len(gbt.nash.enumpure_solve(game, use_strategic=False).equilibria) == 0
 
 
-def test_enummixed_strategy_double():
-    """Test calls of enumeration of mixed strategy equilibria, floating-point."""
+def test_enummixed_double():
+    """Test calls of enumeration of mixed strategy equilibria for 2-player games, floating-point.
+    """
     game = games.read_from_file("poker.efg")
     result = gbt.nash.enummixed_solve(game, rational=False)
     assert len(result.equilibria) == 1
@@ -38,7 +40,7 @@ def test_enummixed_strategy_double():
 
 @pytest.mark.nash
 @pytest.mark.nash_enummixed_strategy
-def test_enummixed_strategy_rational():
+def test_enummixed_rational():
     """Test calls of enumeration of mixed strategy equilibria, rational precision."""
     game = games.read_from_file("poker.efg")
     result = gbt.nash.enummixed_solve(game, rational=True)
@@ -100,8 +102,8 @@ def test_enummixed_strategy_rational():
                 [[["1/2", "1/2"]], [["2/5", "3/5"]], [["1/4", "3/4"]]],
                 [[["2/5", "3/5"]], [["1/2", "1/2"]], [["1/3", "2/3"]]],
             ],
-            2,
-        ),  # 9 in total found by enumpoly
+            2,  # 9 in total found by enumpoly
+        ),
     ],
 )
 def test_enumpoly_behavior_strategy_rational(
@@ -158,7 +160,7 @@ def test_lcp_mixed_strategy_rational():
     assert result.equilibria[0] == expected
 
 
-def test_lcp_behavior_strategy_floating():
+def test_lcp_behavior_strategy_double():
     """Test calls of LCP for mixed behavior equilibria, floating-point."""
     game = games.read_from_file("poker.efg")
     result = gbt.nash.lcp_solve(game, use_strategic=False, rational=False)
@@ -258,7 +260,7 @@ def test_lp_mixed_strategy_rational():
     assert result.equilibria[0] == expected
 
 
-def test_lp_behavior_strategy_floating():
+def test_lp_behavior_strategy_double():
     """Test calls of LP for mixed behavior equilibria, floating-point."""
     game = games.read_from_file("poker.efg")
     result = gbt.nash.lp_solve(game, use_strategic=False, rational=False)