Regression fix for premature invalidation of object.

This corrects a regression which invalidates an information set object
earlier than it should.

This can lead to a segmentation fault in certain situations, as in effect `delete this` is
called before it ought to be.

Author: tturocy

.github/workflows/python.yml

@@ -32,6 +32,52 @@ jobs:
       - name: Run tests
         run: pytest
 
+  macos-13:
+    runs-on: macos-13
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
+    strategy:
+      matrix:
+        python-version: ['3.12']
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Set up dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install cython pytest wheel lxml numpy scipy
+      - name: Build extension
+        run: |
+          python -m pip install -v .
+      - name: Run tests
+        run: pytest
+
+  macos-14:
+    runs-on: macos-14
+    if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
+    strategy:
+      matrix:
+        python-version: ['3.12']
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Set up dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install cython pytest wheel lxml numpy scipy
+      - name: Build extension
+        run: |
+          python -m pip install -v .
+      - name: Run tests
+        run: pytest
+
   windows:
     runs-on: windows-latest
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name

src/games/gametree.cc

@@ -139,7 +139,6 @@ void GameTreeActionRep::DeleteAction()
     member->children[where]->Invalidate();
     erase_atindex(member->children, where);
   }
-
   if (m_infoset->IsChanceInfoset()) {
     m_infoset->m_efg->NormalizeChanceProbs(m_infoset);
   }
@@ -277,11 +276,11 @@ void GameTreeInfosetRep::RemoveMember(GameTreeNodeRep *p_node)
   if (m_members.empty()) {
     m_player->m_infosets.erase(
         std::find(m_player->m_infosets.begin(), m_player->m_infosets.end(), this));
-    Invalidate();
     int iset = 1;
     for (auto &infoset : m_player->m_infosets) {
       infoset->m_number = iset++;
     }
+    Invalidate();
   }
 }