Merge branch 'master' into dev_terminology

# Conflicts:
#	tests/test_game.py

Author: tturocy

.github/pull_request_template.md

@@ -0,0 +1,24 @@
+_Thanks for contributing to Gambit! Before you submitting or reviewing a pull request, check out our [guidelines for contributing](https://gambitproject.readthedocs.io/en/latest/developer.contributing.html)._
+
+_The person submitting the PR should ensure it has an informative title and update the headers below, before marking the PR as ready for review and assigning reviewers._
+
+### Issues closed by this PR
+
+_Add any issues that are being closed by this PR to the list. Use "Closes" or [another keyword](https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) followed by the issue number._
+
+- Closes #ISSUE_NUMBER
+
+### Description of the changes in this PR
+
+_Update the description of the changes made in this PR. You can delete this section if the changes are already fully described in the linked issues._
+
+This PR ...
+
+### How to review this PR
+
+_The gambit repository contains source code and documentation for several different components. Explain how a reviewer should approach reviewing the specific changes made in this PR._
+
+_For example, you might include instructions like:_
+- _"Review code changes and ensure tests cover edge cases"_
+- _"Rebuild the GUI from this branch, then test features X, Y, Z work as expected"_
+- _"Click the link to the documentation page and sense check by reading"_

.github/workflows/osxbinary.yml

@@ -31,7 +31,7 @@ jobs:
       - run: make
       - run: sudo make install
       - run: make osx-dmg
-      - uses: actions/upload-artifact@v5
+      - uses: actions/upload-artifact@v6
         with:
           name: artifact-osx-14
           path: "*.dmg"

.github/workflows/python.yml

@@ -34,7 +34,7 @@ jobs:
       - name: Run tests
         run: pytest --run-tutorials
 
-  macos-13:
+  macos-14:
     runs-on: macos-14
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     strategy:
@@ -52,13 +52,14 @@ jobs:
           python -m pip install --upgrade pip
           pip install setuptools build cython wheel
           pip install -r tests/requirements.txt
+          pip install -r doc/requirements.txt
       - name: Build extension
         run: |
           python -m pip install -v .
       - name: Run tests
-        run: pytest
+        run: pytest --run-tutorials
 
-  macos-14:
+  macos-15:
     runs-on: macos-15
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     strategy:

.github/workflows/tools.yml

@@ -46,7 +46,7 @@ jobs:
       - run: make
       - run: sudo make install
       - run: make osx-dmg
-      - uses: actions/upload-artifact@v5
+      - uses: actions/upload-artifact@v6
         with:
           name: artifact-osx-14
           path: "*.dmg"
@@ -65,7 +65,7 @@ jobs:
       - run: make
       - run: sudo make install
       - run: make osx-dmg
-      - uses: actions/upload-artifact@v5
+      - uses: actions/upload-artifact@v6
         with:
           name: artifact-osx-15
           path: "*.dmg"
@@ -93,7 +93,7 @@ jobs:
           cp gambit* installer
           "${WIX}bin/candle" build_support/msw/gambit.wxs
           "${WIX}bin/light" -ext WixUIExtension gambit.wixobj
-      - uses: actions/upload-artifact@v5
+      - uses: actions/upload-artifact@v6
         with:
           name: artifact-msw
           path: "*.msi"

.github/workflows/wheels.yml

@@ -27,6 +27,6 @@ jobs:
           python -m cibuildwheel --output-dir wheelhouse/
         env:
           CIBW_SKIP: "pp*"
-      - uses: actions/upload-artifact@v5
+      - uses: actions/upload-artifact@v6
         with:
           path: ./wheelhouse/*.whl

.gitignore

@@ -43,5 +43,8 @@ Gambit.app/*
 *.so
 doc/tutorials/games/*.nfg
 doc/tutorials/games/*.efg
+doc/tutorials/*.png
 *.dmg
 Gambit.app/*
+*.ipynb_checkpoints
+*.ef

.readthedocs.yml

@@ -12,6 +12,7 @@ build:
   apt_packages:
     - libgmp-dev
     - pandoc
+    - texlive-full
 
 python:
   install:

ChangeLog

@@ -2,6 +2,10 @@
 
 ## [16.5.0] - unreleased
 
+### Added
+- Implement `IsAbsentMinded()` on information sets (C++) and `Infoset.is_absent_minded` (Python)
+  to detect if an information is absent-minded.
+
 ### Changed
 - In the graphical interface, removed option to configure information set link drawing; information sets
   are always drawn and indicators are always drawn if an information set spans multiple levels.

Makefile.am

@@ -251,14 +251,11 @@ core_SOURCES = \
 	src/core/recarray.h \
 	src/core/matrix.h \
 	src/core/matrix.imp \
-	src/core/sqmatrix.h \
-	src/core/sqmatrix.imp \
 	src/core/integer.cc \
 	src/core/integer.h \
 	src/core/rational.cc \
 	src/core/rational.h \
 	src/core/matrix.cc \
-	src/core/sqmatrix.cc \
 	src/core/function.cc \
 	src/core/function.h \
 	src/core/tinyxml.cc \
@@ -407,7 +404,6 @@ gambit_enumpoly_SOURCES = \
 	src/solvers/enumpoly/rectangle.h \
 	src/solvers/enumpoly/poly.cc \
 	src/solvers/enumpoly/poly.h \
-	src/solvers/enumpoly/poly.imp \
 	src/solvers/enumpoly/polysystem.h \
     src/solvers/enumpoly/polypartial.h \
     src/solvers/enumpoly/polypartial.imp \
@@ -568,7 +564,6 @@ gambit_SOURCES = \
 	src/gui/dlefglogit.cc \
 	src/gui/dlefglogit.h \
 	src/gui/dlefgreveal.cc \
-	src/gui/dlefgreveal.h \
 	src/gui/dlexcept.h \
 	src/gui/dlgameprop.cc \
 	src/gui/dlgameprop.h \

doc/developer.contributing.rst

@@ -37,8 +37,8 @@ version.
 
 1. To get started contributing code in the `Gambit GitHub repo <https://github.com/gambitproject/gambit>`__, do one of the following:
 
-- Core developers: request contributor access from one of the `team <https://www.gambit-project.org/team/>`__
-- External contributors: fork the repository on GitHub.
+   - Core developers: request contributor access from one of the `team <https://www.gambit-project.org/team/>`__
+   - External contributors: fork the repository on GitHub.
 
 2. Clone the repository to your local machine ::
 
@@ -63,9 +63,9 @@ version.
 
    Having `pre-commit` installed is recommended as it runs many of the same checks that are automatically conducted on any pull request.  Every time you commit, it will automatically fix some issues and highlight others for manual adjustment.
 
-5. Create a new branch for your changes ::
+5. Create a new branch for your changes. It's good practice to either give the branch a descriptive name or directly reference an issue number ::
 
-    git checkout -b feature/your-feature-name
+    git checkout -b feature/issue-number
 
 6. Make your changes. ::
 
@@ -78,11 +78,22 @@ version.
 
 7. Push your changes to your fork or branch ::
 
-    git push origin feature/your-feature-name
+    git push origin feature/issue-number
+
+8. Open a pull request on GitHub to the master branch of the upstream repository. Ensure your pull request:
+
+   - Has an informative title.
+   - Links to any relevant issues.
+   - Includes a clear description of the changes made.
+   - Explains how a reviewer can test the changes.
+
+   .. note::
+      It's good practice to open a draft pull request early in the development process to facilitate discussion and feedback, ensure there are no merge conflicts, and allow for continuous integration testing via GitHub Actions.
 
-8. Open a pull request on GitHub to the master branch of the upstream repository, describing your changes and linking to any relevant issues.
 9. Core developers will review your changes, provide feedback, and merge them into the master branch if they meet the project's standards.
 
+10. Once your pull request is merged, delete your branch on GitHub (a button should appear to do this automatically).
+
 Testing your changes
 --------------------