removed create_3_player_with_internal_outcomes_efg and create_large_payoff_game from games.py

Author: rahulsavani

tests/games.py

@@ -185,80 +185,6 @@ def create_non_zero_sum_lacking_outcome_efg(missing_term_outcome: bool = False)
     return g
 
 
-def create_large_payoff_game_efg() -> gbt.Game:
-    g = gbt.Game.new_tree(players=["1", "2"], title="Large payoff game")
-    g.append_move(g.root, g.players.chance, ["L", "R"])
-    for i in range(2):
-        g.append_move(g.root.children[i], "1", ["A", "B"])
-    for i in range(2):
-        g.append_move(g.root.children[0].children[i], "2", ["X", "Y"])
-        g.append_infoset(g.root.children[1].children[i], g.root.children[0].children[i].infoset)
-    o_large = g.add_outcome([10000000000000000000, -10000000000000000000], label="large payoff")
-    o_1 = g.add_outcome([1, -1], label="1")
-    o_m1 = g.add_outcome([-1, 1], label="-1")
-    o_zero = g.add_outcome([0, 0], label="0")
-    g.set_outcome(g.root.children[0].children[0].children[0], o_large)
-    g.set_outcome(g.root.children[0].children[0].children[1], o_1)
-    g.set_outcome(g.root.children[0].children[1].children[0], o_m1)
-    g.set_outcome(g.root.children[0].children[1].children[1], o_zero)
-    g.set_outcome(g.root.children[1].children[0].children[0], o_m1)
-    g.set_outcome(g.root.children[1].children[0].children[1], o_1)
-    g.set_outcome(g.root.children[1].children[1].children[0], o_zero)
-    g.set_outcome(g.root.children[1].children[1].children[1], o_large)
-    g.to_efg("large_payoff_game.efg")
-    return g
-
-
-def create_3_player_with_internal_outcomes_efg(nonterm_outcomes: bool = False) -> gbt.Game:
-    g = gbt.Game.new_tree(players=["1", "2", "3"], title="3 player game")
-    g.append_move(g.root, g.players.chance, ["H", "T"])
-    g.set_chance_probs(g.root.infoset, ["1/2", "1/2"])
-    g.append_move(g.root.children[0], "1", ["a", "b"])
-    g.append_move(g.root.children[1], "1", ["c", "d"])
-    g.append_move(g.root.children[0].children[0], "2", ["A", "B"])
-    g.append_infoset(g.root.children[1].children[0], g.root.children[0].children[0].infoset)
-    g.append_move(g.root.children[0].children[1], "3", ["W", "X"])
-    g.append_infoset(g.root.children[1].children[1], g.root.children[0].children[1].infoset)
-    g.append_move(g.root.children[0].children[0].children[0], "3", ["Y", "Z"])
-    iset = g.root.children[0].children[0].children[0].infoset
-    g.append_infoset(g.root.children[0].children[0].children[1], iset)
-    g.append_move(g.root.children[0].children[1].children[1], "2", ["C", "D"])
-    o = g.add_outcome([3, 1, 4])
-    g.set_outcome(g.root.children[0].children[0].children[0].children[0], o)
-    o = g.add_outcome([4, 0, 1])
-    g.set_outcome(g.root.children[0].children[0].children[0].children[1], o)
-    o = g.add_outcome([1, 3, 2])
-    g.set_outcome(g.root.children[0].children[1].children[0], o)
-    o = g.add_outcome([2, 4, 1])
-    g.set_outcome(g.root.children[0].children[1].children[1].children[0], o)
-    o = g.add_outcome([4, 1, 3])
-    g.set_outcome(g.root.children[0].children[1].children[1].children[1], o)
-    if nonterm_outcomes:
-        o = g.add_outcome([1, 2, 3])
-        g.set_outcome(g.root.children[1], o)
-        o = g.add_outcome([1, 0, 1])
-        g.set_outcome(g.root.children[1].children[0].children[0], o)
-        o = g.add_outcome([2, -1, -2])
-        g.set_outcome(g.root.children[1].children[0].children[1], o)
-        o = g.add_outcome([-1, 2, -1])
-        g.set_outcome(g.root.children[1].children[1].children[0], o)
-    else:
-        o = g.add_outcome([2, 2, 4])
-        g.set_outcome(g.root.children[1].children[0].children[0], o)
-        o = g.add_outcome([3, 1, 1])
-        g.set_outcome(g.root.children[1].children[0].children[1], o)
-        o = g.add_outcome([0, 4, 2])
-        g.set_outcome(g.root.children[1].children[1].children[0], o)
-        o = g.add_outcome([1, 2, 3])
-        g.set_outcome(g.root.children[1].children[1].children[1], o)
-        o = g.add_outcome([0, 0, 0])
-        g.set_outcome(g.root.children[0].children[0].children[1].children[0], o)
-        g.set_outcome(g.root.children[0].children[0].children[1].children[1], o)
-    tmp = "_with_nonterm_outcomes" if nonterm_outcomes else ""
-    g.to_efg(f"3_player{tmp}.efg")
-    return g
-
-
 def create_matching_pennies_efg(with_neutral_outcome: bool = False) -> gbt.Game:
     """
     TODO: use create_efg_corresponding_to_bimatrix_game

tests/test_behav.py

@@ -843,8 +843,8 @@ def test_infoset_regret_consistency(game: gbt.Game, rational_flag: bool):
      (games.create_stripped_down_poker_efg(), True),
      (games.create_kuhn_poker_efg(), False),
      (games.create_kuhn_poker_efg(), True),
-     (games.create_3_player_with_internal_outcomes_efg(), False),
-     (games.create_3_player_with_internal_outcomes_efg(), True)
+     (games.read_from_file("3_player.efg"), False),
+     (games.read_from_file("3_player.efg"), True)
      ]
 )
 def test_max_regret_consistency(game: gbt.Game, rational_flag: bool):

tests/test_extensive.py

@@ -405,8 +405,8 @@ def test_reduced_strategic_form(
             games.read_from_file("two_player_perfect_info_win_lose_with_nonterm_outcomes.efg")
         ),
         (
-            games.create_3_player_with_internal_outcomes_efg(),
-            games.create_3_player_with_internal_outcomes_efg(nonterm_outcomes=True)
+            games.read_from_file("3_player.efg"),
+            games.read_from_file("3_player_with_nonterm_outcomes.efg")
         ),
         (
             games.read_from_file("chance_in_middle.efg"),

tests/test_games/3_player.efg

@@ -0,0 +1,24 @@
+EFG 2 R "3 player game" { "1" "2" "3" }
+""
+
+c "" 1 "" { "H" 1/2 "T" 1/2 } 0
+p "" 1 1 "" { "a" "b" } 0
+p "" 2 1 "" { "A" "B" } 0
+p "" 3 2 "" { "Y" "Z" } 0
+t "" 1 "" { 3, 1, 4 }
+t "" 2 "" { 4, 0, 1 }
+p "" 3 2 "" { "Y" "Z" } 0
+t "" 10 "" { 0, 0, 0 }
+t "" 10 "" { 0, 0, 0 }
+p "" 3 1 "" { "W" "X" } 0
+t "" 3 "" { 1, 3, 2 }
+p "" 2 2 "" { "C" "D" } 0
+t "" 4 "" { 2, 4, 1 }
+t "" 5 "" { 4, 1, 3 }
+p "" 1 2 "" { "c" "d" } 0
+p "" 2 1 "" { "A" "B" } 0
+t "" 6 "" { 2, 2, 4 }
+t "" 7 "" { 3, 1, 1 }
+p "" 3 1 "" { "W" "X" } 0
+t "" 8 "" { 0, 4, 2 }
+t "" 9 "" { 1, 2, 3 }

tests/test_games/3_player_with_nonterm_outcomes.efg

@@ -0,0 +1,24 @@
+EFG 2 R "3 player game" { "1" "2" "3" }
+""
+
+c "" 1 "" { "H" 1/2 "T" 1/2 } 0
+p "" 1 1 "" { "a" "b" } 0
+p "" 2 1 "" { "A" "B" } 0
+p "" 3 2 "" { "Y" "Z" } 0
+t "" 1 "" { 3, 1, 4 }
+t "" 2 "" { 4, 0, 1 }
+p "" 3 2 "" { "Y" "Z" } 0
+t "" 0
+t "" 0
+p "" 3 1 "" { "W" "X" } 0
+t "" 3 "" { 1, 3, 2 }
+p "" 2 2 "" { "C" "D" } 0
+t "" 4 "" { 2, 4, 1 }
+t "" 5 "" { 4, 1, 3 }
+p "" 1 2 "" { "c" "d" } 6 "" { 1, 2, 3 }
+p "" 2 1 "" { "A" "B" } 0
+t "" 7 "" { 1, 0, 1 }
+t "" 8 "" { 2, -1, -2 }
+p "" 3 1 "" { "W" "X" } 0
+t "" 9 "" { -1, 2, -1 }
+t "" 0

tests/test_games/large_payoff_game.efg

@@ -0,0 +1,18 @@
+EFG 2 R "Large payoff game" { "1" "2" }
+""
+
+c "" 1 "" { "L" 1/2 "R" 1/2 } 0
+p "" 1 1 "" { "A" "B" } 0
+p "" 2 1 "" { "X" "Y" } 0
+t "" 1 "large payoff" { 10000000000000000000, -10000000000000000000 }
+t "" 2 "1" { 1, -1 }
+p "" 2 2 "" { "X" "Y" } 0
+t "" 3 "-1" { -1, 1 }
+t "" 4 "0" { 0, 0 }
+p "" 1 2 "" { "A" "B" } 0
+p "" 2 1 "" { "X" "Y" } 0
+t "" 3 "-1" { -1, 1 }
+t "" 2 "1" { 1, -1 }
+p "" 2 2 "" { "X" "Y" } 0
+t "" 4 "0" { 0, 0 }
+t "" 1 "large payoff" { 10000000000000000000, -10000000000000000000 }

tests/test_nash.py

@@ -249,15 +249,15 @@ def test_enummixed_rational(game: gbt.Game, mixed_strategy_prof_data: list):
         ##############################################################################
         ##############################################################################
         (
-            games.create_3_player_with_internal_outcomes_efg(),
+            games.read_from_file("3_player.efg"),
             [
                 [[[1, 0], [1, 0]], [[1, 0], ["1/2", "1/2"]], [[1, 0], [0, 1]]],
                 [[[1, 0], [1, 0]], [[1, 0], [0, 1]],
                     [[1, 0], ["1/3", "2/3"]]]],
             2,
         ),
         (
-            games.create_3_player_with_internal_outcomes_efg(nonterm_outcomes=True),
+            games.read_from_file("3_player_with_nonterm_outcomes.efg"),
             [
                 [[[1, 0], [1, 0]], [[1, 0], ["1/2", "1/2"]], [[1, 0], [0, 1]]],
                 [[[1, 0], [1, 0]], [[1, 0], [0, 1]],
@@ -579,7 +579,7 @@ def test_lcp_behavior_double():
             ],
         ),
         (
-                games.create_large_payoff_game_efg(),
+                games.read_from_file("large_payoff_game.efg"),
                 [
                     [[1, 0], [1, 0]],
                     [[0, 1], ["9999999999999999999/10000000000000000000",
@@ -784,7 +784,7 @@ def test_lp_behavior_double():
             ],
         ),
         (
-                games.create_large_payoff_game_efg(),
+                games.read_from_file("large_payoff_game.efg"),
                 [
                     [[1, 0], [1, 0]],
                     [[0, 1], ["9999999999999999999/10000000000000000000",