test_enumpure_agent using agent_max_regret()

Author: rahulsavani

.all-contributorsrc

@@ -34,7 +34,7 @@
         "ideas"
       ]
     },
-    {  
+    {
       "login": "edwardchalstrey1",
       "name": "Ed Chalstrey",
       "avatar_url": "https://avatars.githubusercontent.com/u/5486164?v=4",

.devcontainer/devcontainer.json

@@ -3,7 +3,7 @@
   "features": {
     "ghcr.io/devcontainers/features/python:1": {
       "installTools": true,
-      "version": "3.11"
+      "version": "3.14"
     },
     "ghcr.io/devcontainers-contrib/features/gdbgui:2": {
       "version": "latest"

.github/ISSUE_TEMPLATE/tutorial_request.yml

@@ -0,0 +1,35 @@
+name: Tutorial request
+description: Submit a request for a new tutorial to be added to the Gambit documentation.
+title: "[Tutorial]: "
+labels: ["tutorial", "documentation"]
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to fill out this tutorial request!
+  - type: textarea
+    id: describe
+    attributes:
+      label: Describe the tutorial you want to see.
+      description: Go into as much detail as you can regarding the tutorial you would like to see, how long it should be etc.
+      placeholder: "E.g. A step-by-step guide showing how to use PyGambit to compute equilibria for normal and extensive form games..."
+      value: "Add a tutorial demonstrating the core components of the PyGambit API."
+    validations:
+      required: true
+  - type: textarea
+    id: who
+    attributes:
+      label: Who is the tutorial for?
+      description: Explain who the target audience is for this tutorial and what prior knowledge they should have.
+      placeholder: "E.g. Beginners in game theory who know basic Python."
+      value: "Newcomers to game theory and the Gambit software who have basic Python programming skills."
+    validations:
+      required: true
+  - type: textarea
+    id: links
+    attributes:
+      label: Add links to papers and software.
+      description: Add links to any research papers or other resources the author will need to write this tutorial.
+      value: "`[Markdown link text](url)`"
+    validations:
+      required: false

.github/pull_request_template.md

@@ -0,0 +1,24 @@
+_Thanks for contributing to Gambit! Before you submitting or reviewing a pull request, check out our [guidelines for contributing](https://gambitproject.readthedocs.io/en/latest/developer.contributing.html)._
+
+_The person submitting the PR should ensure it has an informative title and update the headers below, before marking the PR as ready for review and assigning reviewers._
+
+### Issues closed by this PR
+
+_Add any issues that are being closed by this PR to the list. Use "Closes" or [another keyword](https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) followed by the issue number._
+
+- Closes #ISSUE_NUMBER
+
+### Description of the changes in this PR
+
+_Update the description of the changes made in this PR. You can delete this section if the changes are already fully described in the linked issues._
+
+This PR ...
+
+### How to review this PR
+
+_The gambit repository contains source code and documentation for several different components. Explain how a reviewer should approach reviewing the specific changes made in this PR._
+
+_For example, you might include instructions like:_
+- _"Review code changes and ensure tests cover edge cases"_
+- _"Rebuild the GUI from this branch, then test features X, Y, Z work as expected"_
+- _"Click the link to the documentation page and sense check by reading"_

.github/workflows/lint.yml

@@ -2,22 +2,14 @@ name: Linters and coding standards checks
 
 on:
   push:
-    paths-ignore:
-      - 'doc/**'
-      - '.github/ISSUE_TEMPLATE/**'
-      - 'README.md'
   pull_request:
-    paths-ignore:
-      - 'doc/**'
-      - '.github/ISSUE_TEMPLATE/**'
-      - 'README.md'
 
 jobs:
   clang-format:
     name: clang-format
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Run clang-format style check for C/C++
         uses: jidicula/clang-format-action@v4.16.0
         with:
@@ -29,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Install dependencies
         run: |
           sudo apt-key adv --fetch-keys http://repos.codelite.org/CodeLite.asc
@@ -45,28 +37,28 @@ jobs:
     runs-on: ubuntu-latest
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: chartboost/ruff-action@v1
 
   flake8:
     runs-on: ubuntu-latest
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - uses: actions/setup-python@v6
         with:
-          python-version: "3.12"
+          python-version: "3.14"
       - uses: py-actions/flake8@v2
 
   cython-lint:
     runs-on: ubuntu-latest
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Setup Python
         uses: actions/setup-python@v6
         with:
-          python-version: "3.12"
+          python-version: "3.14"
       - name: Install Python packages
         run: python -m pip install cython-lint
       - name: cython-lint

.github/workflows/osxbinary.yml

@@ -2,21 +2,17 @@ name: MacOS static GUI binary
 
 on:
   push:
-    paths-ignore:
-      - 'doc/**'
-      - '.github/ISSUE_TEMPLATE/**'
-      - 'README.md'
     tags:
       - 'v*'
   schedule:
     - cron: '0 6 * * 4'
 
 jobs:
   macos-13:
-    runs-on: macos-13
+    runs-on: macos-14
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Install dependencies
         run: |
             brew install automake autoconf
@@ -35,7 +31,7 @@ jobs:
       - run: make
       - run: sudo make install
       - run: make osx-dmg
-      - uses: actions/upload-artifact@v5
+      - uses: actions/upload-artifact@v6
         with:
-          name: artifact-osx-13
+          name: artifact-osx-14
           path: "*.dmg"

.github/workflows/python.yml

@@ -2,34 +2,28 @@ name: pygambit Python extension
 
 on:
   push:
-    paths-ignore:
-      - 'doc/**'
-      - '.github/ISSUE_TEMPLATE/**'
-      - 'README.md'
   pull_request:
-    paths-ignore:
-      - 'doc/**'
-      - '.github/ISSUE_TEMPLATE/**'
-      - 'README.md'
 
 jobs:
   linux:
     runs-on: ubuntu-latest
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     strategy:
       matrix:
-        python-version: ['3.9', '3.13']
+        python-version: ['3.10', '3.14']
 
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v6
         with:
           python-version: ${{ matrix.python-version }}
       - name: Set up dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install setuptools build cython pytest pytest-skip-slow wheel lxml numpy scipy
+          pip install setuptools build cython wheel
+          pip install -r tests/requirements.txt
+          pip install -r doc/requirements.txt
       - name: Build source distribution
         run:
           python -m build
@@ -38,73 +32,79 @@ jobs:
           cd dist
           pip install -v pygambit*.tar.gz
       - name: Run tests
-        run: pytest
+        run: pytest --run-tutorials
 
-  macos-13:
-    runs-on: macos-13
+  macos-14:
+    runs-on: macos-14
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     strategy:
       matrix:
-        python-version: ['3.13']
+        python-version: ['3.14']
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v6
         with:
           python-version: ${{ matrix.python-version }}
       - name: Set up dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install cython pytest pytest-skip-slow wheel lxml numpy scipy
+          pip install setuptools build cython wheel
+          pip install -r tests/requirements.txt
+          pip install -r doc/requirements.txt
       - name: Build extension
         run: |
           python -m pip install -v .
       - name: Run tests
-        run: pytest
+        run: pytest --run-tutorials
 
-  macos-14:
-    runs-on: macos-14
+  macos-15:
+    runs-on: macos-15
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     strategy:
       matrix:
-        python-version: ['3.13']
+        python-version: ['3.14']
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v6
         with:
           python-version: ${{ matrix.python-version }}
       - name: Set up dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install cython pytest pytest-skip-slow wheel lxml numpy scipy
+          pip install setuptools build cython wheel
+          pip install -r tests/requirements.txt
+          pip install -r doc/requirements.txt
       - name: Build extension
         run: |
           python -m pip install -v .
       - name: Run tests
-        run: pytest
+        run: pytest --run-tutorials
 
   windows:
     runs-on: windows-latest
     if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
     strategy:
       matrix:
-        python-version: ['3.13']
+        python-version: ['3.14']
 
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Set up Python ${{ matrix.python-version }}
         uses: actions/setup-python@v6
         with:
           python-version: ${{ matrix.python-version }}
       - name: Set up dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install cython pytest pytest-skip-slow wheel lxml numpy scipy
+          pip install setuptools build cython wheel
+          pip install -r tests/requirements.txt
+          pip install -r doc/requirements.txt
       - name: Build extension
         run: |
           python -m pip install -v .
       - name: Run tests
-        run: pytest
+        run: pytest --run-tutorials