Skip to content

Commit dd0359e

Browse files
committed
Remove dead code: sample detection, media info pipeline, subtitles, raw disk
Removed entire sample detection chain (DetectSample, NotSampleSpecification) — games don't have sample files. Simplified callers to skip sample checks. Removed UpdateMediaInfoService and its consumers — was a no-op after FFMpeg removal but still injected in DiskScanService and FileNameBuilder. Removed AugmentQualityFromMediaInfo — used video resolution from MediaInfo which is never populated for games. Removed RawDiskSpecification — rejected Blu-ray/DVD patterns but also falsely rejected valid game ISOs. Gutted MediaInfo token registration in FileNameBuilder — tokens still registered (for naming format compat) but resolve to empty immediately. Removed hardcoded subtitle parsing (HardcodedSubsRegex, ParseHardcodeSubs, HardcodedSubs property) — games don't have hardcoded subtitles. Removed XbmcMetadata movie remnants (watched/playcount/lastplayed/top250). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent eefb377 commit dd0359e

25 files changed

Lines changed: 30 additions & 879 deletions

File tree

src/NzbDrone.Core.Test/DecisionEngineTests/RawDiskSpecificationFixture.cs

Lines changed: 0 additions & 98 deletions
This file was deleted.

src/NzbDrone.Core.Test/MediaFiles/DownloadedGamesImportServiceFixture.cs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -283,10 +283,6 @@ public void should_delete_folder_if_files_were_imported_and_only_sample_files_re
283283
.Setup(s => s.Import(It.IsAny<List<ImportDecision>>(), true, null, ImportMode.Auto))
284284
.Returns(imported.Select(i => new ImportResult(i)).ToList());
285285

286-
Mocker.GetMock<IDetectSample>()
287-
.Setup(s => s.IsSample(It.IsAny<GameMetadata>(),
288-
It.IsAny<string>()))
289-
.Returns(DetectSampleResult.Sample);
290286

291287
Subject.ProcessRootFolder(new DirectoryInfo(_droneFactory));
292288

@@ -352,10 +348,6 @@ public void should_not_delete_if_there_is_large_rar_file()
352348
.Setup(s => s.Import(It.IsAny<List<ImportDecision>>(), true, null, ImportMode.Auto))
353349
.Returns(imported.Select(i => new ImportResult(i)).ToList());
354350

355-
Mocker.GetMock<IDetectSample>()
356-
.Setup(s => s.IsSample(It.IsAny<GameMetadata>(),
357-
It.IsAny<string>()))
358-
.Returns(DetectSampleResult.Sample);
359351

360352
Mocker.GetMock<IDiskProvider>()
361353
.Setup(s => s.GetFiles(It.IsAny<string>(), true))
@@ -459,10 +451,6 @@ public void should_not_delete_if_no_files_were_imported()
459451
.Setup(s => s.Import(It.IsAny<List<ImportDecision>>(), true, null, ImportMode.Auto))
460452
.Returns(new List<ImportResult>());
461453

462-
Mocker.GetMock<IDetectSample>()
463-
.Setup(s => s.IsSample(It.IsAny<GameMetadata>(),
464-
It.IsAny<string>()))
465-
.Returns(DetectSampleResult.Sample);
466454

467455
Mocker.GetMock<IDiskProvider>()
468456
.Setup(s => s.GetFileSize(It.IsAny<string>()))

src/NzbDrone.Core.Test/MediaFiles/GameImport/Aggregation/Aggregators/Augmenters/Quality/AugmentQualityFromMediaInfoFixture.cs

Lines changed: 0 additions & 114 deletions
This file was deleted.

src/NzbDrone.Core.Test/MediaFiles/GameImport/DetectSampleFixture.cs

Lines changed: 0 additions & 49 deletions
This file was deleted.

src/NzbDrone.Core.Test/MediaFiles/GameImport/Specifications/NotSampleSpecificationFixture.cs

Lines changed: 0 additions & 37 deletions
This file was deleted.

src/NzbDrone.Core.Test/MediaFiles/MediaInfo/UpdateMediaInfoServiceFixture.cs

Lines changed: 0 additions & 51 deletions
This file was deleted.

0 commit comments

Comments
 (0)