Building against Node 10 fails.

[corvinrok]

Compile when trying to npm install this package fails on Node 10 based Windows platform/env :

c:\git\my-project\node_modules\libxmljs-mt\node_modules\nan\nan_maybe_43_inl.h(112): error C2039: 'ForceSet': is not a member of 'v8::Object' (compiling source file ..\src\xml_element.cc) [C:\git\my-project\node_modules\libxmljs-mt\build\xmljs.vcxproj]
  c:\users\myuser\.node-gyp\10.0.0\include\node\v8.h(3111): note: see declaration of 'v8::Object' (compiling source file ..\src\xml_element.cc)
c:\git\my-project\node_modules\libxmljs-mt\node_modules\nan\nan_maybe_43_inl.h(112): error C2039: 'ForceSet': is not a member of 'v8::Object' (compiling source file ..\src\libxmljs.cc) [C:\git\my-project\node_modules\libxmljs-mt\build\xmljs.vcxproj]
  C:\Users\myuser\.node-gyp\10.0.0\include\node\v8.h(3111): note: see declaration of 'v8::Object' (compiling source file ..\src\libxmljs.cc)
c:\git\my-project\node_modules\libxmljs-mt\node_modules\nan\nan_maybe_43_inl.h(112): error C2039: 'ForceSet': is not a member of 'v8::Object' (compiling source file ..\src\xml_attribute.cc) [C:\git\my-project\node_modules\libxmljs-mt\build\xmljs.vcxproj]
  C:\Users\myuser\.node-gyp\10.0.0\include\node\v8.h(3111): note: see declaration of 'v8::Object' (compiling source file ..\src\xml_attribute.cc)
c:\git\my-project\node_modules\libxmljs-mt\node_modules\nan\nan_maybe_43_inl.h(112): error C2039: 'ForceSet': is not a member of 'v8::Object' (compiling source file ..\src\xml_namespace.cc) [C:\git\my-project\node_modules\libxmljs-mt\build\xmljs.vcxproj]

[corvinrok]

@gagern
The latest release from libxmljs https://github.com/libxmljs/libxmljs/releases/tag/v0.18.8 now supports successful build with Node 10. I am hoping that since this is a fork of that library that updating it with libxmljs changes is somewhat trivial to those who know what is up.

If that is not the case, and its too much work to do so, can someone point me to a link or resources where I could begin to learn how I might do a pull request that could move this fork forward to match the supported updates made in the original repo that allows Node 10 support? I'm saying, I'll help, I just honestly don't where to to start exactly.

[rchipka]

@corvinrok Please see these pull requests:

libxmljs#510
libxmljs#508

Some memory management checks had to be bypassed on Node 10.

I allowed the PR to merge so that we can at least have a working Node 10 release available.

[corvinrok]

I guess I should have looked at the PR list. It appears that there is already a PR #14 attempting to do this very thing. @gagern @rchipka

[kevteljeur]

Hi, I've just been working on trying to make https://github.com/albanm/node-libxslt compatible with libxmljs (it's a nice interface to libxslt, which uses libxmljs-mt), but it relies on the async features; I'd have to rewrite it. I'd like to help (although I've no experience with C/C++ or bindings, and I'm aware that it's non-trivial).

[kevteljeur]

Actually, #14 has worked for me and now I'm trying to get that node-libxslt module to build with Node.js 10.x.

Edit: I have it working. Now, it would be great to set up a way to work with the fixed modules that is portable (as in, not installing from local directories, which doesn't scale). So if you use libxmljs and/or node-libxslt and you need to upgrade to Node.js 10.x, this can all be made to work.

Here is the PR: #14 and here is my suggested fix for node-libxslt: albanm/node-libxslt#68 (comment)