-
Notifications
You must be signed in to change notification settings - Fork 79
Open
Description
I tried to push the following tag: v72.94001.10
However, the tag passed to the tag event was the following value:
const { Git } = require('node-git-server');
const repos = new Git('path/to/tmp', {
autoCreate: true,
});
repos.on('tag', (tag) => {
// tag.version === 'v72.94' // What!?
});
repos.listen(49152, { type: 'http' }, () => {
// ...
});
repos.server.on('error', err => { throw err });Apparently, tag names are cut off when 00 is encountered.
I have looked into the reason for this and found the following regular expression to be the cause.
node-git-server/src/service.ts
Line 13 in 2ab22a4
| 'receive-pack': '([0-9a-fA-F]+) ([0-9a-fA-F]+) refs\/(heads|tags)\/(.*?)( |00|\u0000)|^(0000)$', // eslint-disable-line |
This pattern is defined so that tag names after spaces, null characters, or 00 are not retrieved.
Why? Tag names (and branch names) can contain 00. What is the reason for excluding anything after 00?
Metadata
Metadata
Assignees
Labels
No labels