Bad character encoding / special characters omitted

[jmduke]

Special characters (eg !@#$%^) seem to be deleted:

BethRest (Solo Piano Version) by Bon Iver

FETCHING SONG....
You  I by Local Natives

[fzakaria]

I believe I had trouble with the filenames that were created if they were still there.
Filenames are the title tracks at the moment.

the MP3 meta information should be proper hoever?

[jmduke]

In those two above cases as well as a few others, the mp3 file didn't actually have any metadata (I'm guessing this is simply because the hosted file didn't?).

There are a few libraries available (eyeD3, mutagen) that can write ID3 tags, though. I'd be more than happy to submit a PR that adds tags for files which don't have them -- what are your thoughts?

[fzakaria]

I originally had a bunch of this kind of stuff in the script but I opted to
rip it out.
I wanted this script to just be a learning example primarily on how to pull
data from HypeMachine.

It might do better to refactor it into modules with the basic pullar and
people can add additional modules of adding tags.

Farid Zakaria

On Thu, Dec 26, 2013 at 10:12 AM, Justin Duke notifications@github.comwrote:

In those two above cases as well as a few others, the mp3 file didn't
actually have any metadata (I'm guessing this is simply because the hosted
file didn't?).

There are a few libraries available (eyeD3, mutagen) that can write ID3
tags, though. I'd be more than happy to submit a PR that adds tags for
files which don't have them -- what are your thoughts?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11#issuecomment-31229819
.

[jmduke]

Cool, I agree. I'll take a stab at a refactor and submit a PR, if you don't mind.

[fzakaria]

Please do!
Put it as a separate script maybe and we can keep the simple one also so
people can still use it to learn ?
On 29 Dec 2013 15:02, "Justin Duke" notifications@github.com wrote:

Cool, I agree. I'll take a stab at a refactor and submit a PR, if you
don't mind.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11#issuecomment-31327684
.