Only first resource gets replaced.

[nawlbergs]

Im trying to switch from grunt to gulp... this library is very close to what I need... but apparently if you have two identical file references... only the first one will get busted in a particular page.

<script type="text/javascript">
    window.no_cache  = "client/static/js/app.js?v=thisfilegotbustedabc123";  // gets busted
</script>
<script src="client/static/js/app.js"></script>  // <!-- not busted -->

why would I do this? My project passing the md5 of the main js file and is basically using it as a Version number... (among other things). Then in my app.... I use it for additional cachebusting.. like certain ajax requests:

  // ajax httpInterceptor .. 
  // ... some code to get md5 hash etc...
  request.url = request.url + symbol + 'no_cache='+md5;

Maybe I'm doing things unlike most people... but I'm trying to keep the project simple, and implement
a basic level of cache-busting. I've looked at other setups and other options that include things like re-naming files and resources.. that just seems like overkill.

I noticed your using cheerio to loop the dom... but doing a non-global replace... so each element only replaces the first resource found.

Even if you don't want to do a global replace.. this is a bug as its finding a <script src=".."> but busting it somewhere else...

Thoughts...
Thanks.

[nawlbergs]

Instead of

return fileContents.replace(originalAttrValue, originalAttrValueWithoutCacheBusting + '?v=' + hash);

Perhaps

var newValue = originalAttrValueWithoutCacheBusting + '?v=' + hash;
return fileContents.split(originalAttrValue).join(newValue);

split().join() is a lil slower they say.. but.. meh
https://jsperf.com/replace-vs-split-join-vs-replaceall/23

[davinkevin]

I don't think the split().join() is a big problem for us...

My first opinion for your problem is cachebust is not made for replacing value inside js block like yours. It's mainly a side effect of text replacement which lead to what you describe.

BTW, if you have two same <script> block with same url, both should be replaced, because cheerio will have two results and so we will perform two replacement.

From my understanding of what you are doing in your HTML, you use your md5 value as a config element... so I advice you to work with a real config file which should be simpler and better for other configuration. The advantage of this is you can generate, change or update this value simply in your build system and integrate it into your build application. In my project, we are importing package.json to read the version key and using it in our code.