feat(selector): custom elements and attributes

[tiblu]

The need

In Angular we use ng-href on link tags to load custom stylesheet. So we need cache busting to work on ng-href attribute.

The solution

Quick and dirty:

• https://github.com/furzeface/cachebust/blob/master/lib/cachebust.js#L18
  • Hardcode ng-href support - return content.attribs['ng-href'] || content.attribs.href;. The same way we can hardcode ng-src support.
• https://github.com/furzeface/cachebust/blob/master/lib/cachebust.js#L57
  • Hardcode ng-href and ng-src support - var protocolRegEx = /^http(s)?/, elements = $('script[src], script[ng-src], link[rel=stylesheet][href], link[rel=stylesheet][ng-href]');

The discussion

As there may be need for support for other tags (img...) and other custom attributes what would be the preferred way to customize the behavior? Give in some kind of map of elements and attributes?

For ex:
options: { targets: { link: ['href', 'ng-href'], script: ['src', 'ng-src'] } }

Open to all ideas. Once we agree on a solution, I'll implement it.

[davinkevin]

Seems to be a good idea, I don't see any problem now... Do a PR and we will discuss about it there 😄

The only thing I would change is the format of the targets object, even if this seems simple, I prefer a simpler solution where targets is just an array of selector: ['script[src]', 'script[ng-src]', 'link[rel=stylesheet][href]', 'link[rel=stylesheet][ng-href]'].