0.58 very bugged

[askovpen]

if you have time, we can fix all bug.
after update 0.55si->0.58 i get binkp "Security violation" with my uplink.
filesizes in qcc wrong. fix by scroll outbound panel.
not looked on while

[jame]

Do you have an idea of what caused that?

[askovpen]

maybe latest qico tested on freebsd? on linux compile have lot of warnings.

[jame]

Reference also open bug at SourceForge project: https://sourceforge.net/p/qico/bugs/17/

[askovpen]

qctl.c:390:23: warning: ignoring return value of 'getcwd', declared with attribute warn_unused_result [-Wunused-result]
qcc.c:258:9: warning: variable 'y' set but not used [-Wunused-but-set-variable]
qcc.c:516:15: warning: variable 'y' set but not used [-Wunused-but-set-variable]
qcc.c:612:7: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat]
qcc.c:612:7: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Wformat]
qcc.c:612:7: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat]
qcc.c:612:7: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Wformat]
qcc.c:935:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
qcc.c:951:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
config.c:356:13: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t' [-Wformat]
daemon.c:501:8: warning: ignoring return value of 'chdir', declared with attribute warn_unused_result [-Wunused-result]
daemon.c:291:10: warning: ignoring return value of 'fscanf', declared with attribute warn_unused_result [-Wunused-result]
emsi.c:256:2: warning: format '%X' expects argument of type 'unsigned int *', but argument 3 has type 'size_t *' [-Wformat]
emsi.c:562:2: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'size_t' [-Wformat]
emsi.c:562:2: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'size_t' [-Wformat]
hydra.c:1639:26: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat]
hydra.c:1639:26: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat]
hydra.c:1639:26: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Wformat]
hydra.c:1639:26: warning: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat]
hydra.c:1864:22: warning: format '%lx' expects argument of type 'long unsigned int *', but argument 3 has type 'DWORD *' [-Wformat]
hydra.c:1864:22: warning: format '%lx' expects argument of type 'long unsigned int *', but argument 4 has type 'DWORD *' [-Wformat]
hydra.c:1894:26: warning: format '%lx' expects argument of type 'long unsigned int *', but argument 3 has type 'DWORD *' [-Wformat]
hydra.c:1950:26: warning: format '%lx' expects argument of type 'long unsigned int *', but argument 3 has type 'h_timer *' [-Wformat]
hydra.c:1950:26: warning: format '%lx' expects argument of type 'long unsigned int *', but argument 4 has type 'DWORD *' [-Wformat]
hydra.c:1951:26: warning: format '%lx' expects argument of type 'long unsigned int *', but argument 3 has type 'DWORD *' [-Wformat]
hydra.c:1775:27: warning: 'p' may be used uninitialized in this function [-Wmaybe-uninitialized]
log.c:150:4: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' [-Wformat]
log.c:226:3: warning: format not a string literal and no format arguments [-Wformat-security]
/usr/include/bits/stdio2.h:64:3: warning: call to __builtin___snprintf_chk will always overflow destination buffer [enabled by default]
ls_zmodem.c:214:13: warning: variable 'inhex' set but not used [-Wunused-but-set-variable]
ls_zsend.c:373:2: warning: passing argument 3 of 'ls_zsendfinfo' discards 'volatile' qualifier from pointer target type [enabled by default]
main.c:255:9: warning: passing argument 1 of 'get_hostname' from incompatible pointer type [enabled by default]
main.c:223:14: warning: ignoring return value of 'chdir', declared with attribute warn_unused_result [-Wunused-result]
modem.c:317:20: warning: initialization makes pointer from integer without a cast [enabled by default]
modem.c:321:13: warning: comparison between pointer and integer [enabled by default]
modem.c:327:9: warning: passing argument 1 of 'tty_getc' makes integer from pointer without a cast [enabled by default]
modem.c:355:10: warning: comparison between pointer and integer [enabled by default]
modem.c:415:9: warning: implicit declaration of function 'strcasestr' [-Wimplicit-function-declaration]
modem.c:189:14: warning: 'modem_find_device' defined but not used [-Wunused-function]
nodelist.c:518:10: warning: variable 'ndl_i' set but not used [-Wunused-but-set-variable]
outbound.c:313:2: warning: format '%u' expects argument of type 'unsigned int *', but argument 3 has type 'size_t *' [-Wformat]
outbound.c:313:2: warning: format '%u' expects argument of type 'unsigned int *', but argument 4 has type 'size_t *' [-Wformat]
outbound.c:313:2: warning: format '%u' expects argument of type 'unsigned int *', but argument 5 has type 'size_t *' [-Wformat]
outbound.c:313:2: warning: format '%u' expects argument of type 'unsigned int *', but argument 6 has type 'size_t *' [-Wformat]
outbound.c:715:4: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t' [-Wformat]
session.c:506:19: warning: variable 'nfiles' set but not used [-Wunused-but-set-variable]
tools.c:196:3: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'UINT32' [-Wformat]
tools.c:196:3: warning: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'UINT32' [-Wformat]
tools.c:376:12: warning: 'touch' defined but not used [-Wunused-function]
tools.c:363:7: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
tools.c:325:9: warning: ignoring return value of 'fscanf', declared with attribute warn_unused_result [-Wunused-result]
tty.c:634:5: warning: assignment makes pointer from integer without a cast [enabled by default]
tty.c:637:13: warning: assignment makes integer from pointer without a cast [enabled by default]
tty.c:653:8: warning: comparison between pointer and integer [enabled by default]
tty.c:87:13: warning: 'tio_compilation_type' defined but not used [-Wunused-variable]
tty.c:816:13: warning: 'fd_close_all' defined but not used [-Wunused-function]
tty.c:574:9: warning: ignoring return value of 'fscanf', declared with attribute warn_unused_result [-Wunused-result]
tty.c:520:9: warning: ignoring return value of 'fscanf', declared with attribute warn_unused_result [-Wunused-result]
flagexp.y:142:6: warning: unused variable 'fln' [-Wunused-variable]
flaglex.c:1960:12: warning: 'input' defined but not used [-Wunused-function]
binkp.c:220:2: warning: pointer targets in passing argument 1 of 'xstrcpy' differ in signedness [-Wpointer-sign]

[jame]

I do not currently have an FreeBSD system to test it on, so can't see if it's the same or different there.

[askovpen]

No. These warnings and bugs on linux

[jame]

I have seen much the same kind of warnings compiling it on Debian/Ubuntu (which is my primary platform). I have some idea of how to try fixing at least some of warnings but can't currently work on it due to other commitments. If you can help with any of this, you would be more than welcome!

[askovpen]

[jame]

Yes, that file size is very much incorrect and is likely due to a signedness issue; either something that is signed that shouldn't be, or something that isn't signed that should be unsigned.

Was that done on a 32 bit, or a 64 bit system?

[askovpen]

Linux skovpen.org 3.10.17-gentoo #1 SMP Fri Dec 13 20:21:39 MSK 2013 x86_64 Intel(R) Core(TM)2 Duo CPU E8400 @ 3.00GHz GenuineIntel GNU/Linux

[jame]

Not surprised that it's 64 bit; have seen a lot of similar issues with FTN programs (like crashmail and jamnntp, which I maintain the Debian packages for) that originated on 32 bit only systems.

However; the most I've been able to do recently myself is to import some work that someone else in zone 2 (icelan) did, but I haven't even had a chance to look that over.

[askovpen]

on 0.55si:

snprintf(str,MAX_STRING," %5d%c %6d%c  %3d  ",
    SIZES(q->mail),SIZEC(q->mail),SIZES(q->files),SIZEC(q->files),q->try);

on 0.58:

snprintf(str,MAX_STRING," %5lu%c %6lu%c  %3d  ",
    SIZES(q->mail),SIZEC(q->mail),SIZES(q->files),SIZEC(q->files),q->try);

why changed? 0.55 work perfect both on x32 and x64

[jame]

hmm... Need to research it more, but looks like the icelan svn repo I imported to take a look at included a patch by the guy who contacted me, which it showed up in the search I did.

[jame]

Where is that code from? Which file?

[askovpen]

prev code - qcc.c
md5q.c:

char *md5_digest(const char *pwd, const unsigned char *challenge);

return random values on x64:-))