From a2db0659db16c81a55dcf467c615c85e9eef48bb Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Thu, 4 Dec 2025 13:10:45 +0530 Subject: [PATCH 1/2] fix(leaderboard): escape name Signed-off-by: Akhil Narang --- eps/eps/leaderboard.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/eps/eps/leaderboard.py b/eps/eps/leaderboard.py index 24cf91b..bb3d798 100644 --- a/eps/eps/leaderboard.py +++ b/eps/eps/leaderboard.py @@ -45,6 +45,8 @@ def get_energy_point_leaderboard(date_range, company=None, field=None, limit=Non for user in energy_point_users: user_id = user["name"] user["name"] = get_fullname(user["name"]) - user["formatted_name"] = f'{get_fullname(user_id)}' + user[ + "formatted_name" + ] = f'{frappe.utils.html_utils.escape_html(get_fullname(user_id))}' return energy_point_users From 2c56f5f1dfce8ab9c9f974d0b362da701d61100f Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Thu, 4 Dec 2025 13:30:50 +0530 Subject: [PATCH 2/2] chore: sync pre-commit with frappe, format Signed-off-by: Akhil Narang --- .pre-commit-config.yaml | 24 ++++++++++++++++++------ eps/eps/leaderboard.py | 6 +++--- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index b218859..50ca8b2 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -1,16 +1,18 @@ exclude: 'node_modules|.git' default_stages: [pre-commit] +default_install_hook_types: [pre-commit, commit-msg] fail_fast: false repos: - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.3.0 + rev: v5.0.0 hooks: - id: trailing-whitespace files: "eps.*" exclude: ".*json$|.*txt$|.*csv|.*md|.*svg" - - id: check-yaml + - id: no-commit-to-branch + args: ['--branch', 'develop'] - id: check-merge-conflict - id: check-ast - id: check-json @@ -19,14 +21,17 @@ repos: - id: debug-statements - repo: https://github.com/astral-sh/ruff-pre-commit - rev: v0.2.0 + rev: v0.13.2 hooks: - id: ruff - name: "Run ruff linter and apply fixes" - args: ["--fix"] + name: "Run ruff import sorter" + args: ["--select=I", "--fix"] + + - id: ruff + name: "Run ruff linter" - id: ruff-format - name: "Format Python code" + name: "Run ruff formatter" - repo: https://github.com/pre-commit/mirrors-prettier rev: v2.7.1 @@ -61,6 +66,13 @@ repos: eps/public/js/lib/.* )$ + - repo: https://github.com/alessandrojcm/commitlint-pre-commit-hook + rev: v9.22.0 + hooks: + - id: commitlint + stages: [commit-msg] + additional_dependencies: ['conventional-changelog-conventionalcommits'] + ci: autoupdate_schedule: weekly skip: [] diff --git a/eps/eps/leaderboard.py b/eps/eps/leaderboard.py index bb3d798..070991f 100644 --- a/eps/eps/leaderboard.py +++ b/eps/eps/leaderboard.py @@ -45,8 +45,8 @@ def get_energy_point_leaderboard(date_range, company=None, field=None, limit=Non for user in energy_point_users: user_id = user["name"] user["name"] = get_fullname(user["name"]) - user[ - "formatted_name" - ] = f'{frappe.utils.html_utils.escape_html(get_fullname(user_id))}' + user["formatted_name"] = ( + f'{frappe.utils.html_utils.escape_html(get_fullname(user_id))}' + ) return energy_point_users