Skip to content

Suggestion: create package forks off official Meteor repo with git subtree #6

@settinghead

Description

@settinghead

This is just a suggestion and still only a thought in my head.

Based on my understanding, mylar-meteor-changes is responsible for patching a few internal Meteor packages, the most important one probably being ddp, and the patches must be updated accordingly when a new Meteor version comes out.

In order to make this process more maintainable, I was thinking maybe one could do the following:

  1. Create a Meteor package called mylar:ddp. Make this package a git subtree of the folder packages/ddp from the official Meteor repo
  2. Patch mylar-related changes to this package, and publish it to Github/Atmosphere
  3. When a new official Meteor version comes out, update the subtree with git merge -s subtree
  4. If there are conflicts as a result of Meteor change, resolve manually
  5. Commit and publish a new version of mylar:ddp

One can also apply the same process to accounts-base and any other packages that Mylar needs a patch for.

I think the benefit for this approach is that it's likely that the patch will automatically merge with new versions of official dpp package. This also makes the mylar-related changes more visible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions