PS1 in `target-shell` suddenly has no color anymore on macOS

[Schamper]

High priority bug. Running ls and such does give color. Removing the if readline conditional from here "fixes" it:

dissect.target/dissect/target/tools/shell.py

Line 133 in 54808a5

ANSI_COLORS = readline_escape(AnsiColors.as_dict()) if readline else AnsiColors.as_dict()

It worked yesterday...

[yunzheng]

I'm starting to believe it may have never worked on macOS since merging the readline ignore sequences in #1041 ..

[Schamper]

I'm starting to believe it may have never worked on macOS since merging the readline ignore sequences in #1041 ..

I found a screenshot I took 2025-12-19 where it still has color, and I'm very certain I saw it have color at least this or last week.

Edit: a screenshot I took 2026-02-23 does not have color. I repeat, no color.

[yunzheng]

Edit: a screenshot I took 2026-02-23 does not have color. I repeat, no color.

😮