Allow admins to upload new model revisions

[tordanik]

Currently, only the original uploader can create a new revision of a model. This limits my ability as an admin to correct problems reported by users: I can delete/hide the model, but I cannot repair it.

For example, a user has pointed out a problem with model 15 (missing colors as a result of the conversion to glb) which I can repair by editing the model in Blender. However, I'm not able to upload the repaired version to the model repository.

[AyushDharDubey]

Hello @tordanik,

I was actually reluctant to include this feature in #42 , citing concerns about artistic crediting.

However, since the obj2glb conversion script has produced quite a few anomalies, it seems necessary for admins to have the privilege to overwrite models.

That said, while implementing, I’d prefer to have a one-to-many relationship from model to author, so we can properly allow jointly authored sections for such models.

[AyushDharDubey]

I am sorry, the close and reopen was unintentional🥲; my touchpad is having some issues recently.

[lonvia]

For the current conversion issues we can also do a one-time replacement of the model files on the server. Note however that some of the model errors mentioned in that post were already present in the older version. So there is more a general question of what to do when users upload broken models (see also the 4 recent uploads for "Telldenkmal").

[tordanik]

Replacing the models on the server would work for me to address the migration-related issues.

But yes, there is a larger discussion to be had on what to do with flawed models. With our current tools, I guess our options are:

• contact the user and ask them fix it themselves (unlikely to work for models uploaded years ago)
• upload it as a new model and edit any OSM tags to point to that new model instead

[lonvia]

A possible low-tech solution: agree on a tag for flawed models. Admins can add the tag where necessary and users can ignore models with that tag.

[AyushDharDubey]

see also the 4 recent uploads for "Telldenkmal"

I looked into them after karlos' report over community forum; these were actually draco-compressed glTF files. It would be useful to enhance support for such modified versions of glTF models as we come across them. The models themselves weren’t broken and thus passed the glTF validator test.

Since it's not an urgency, I can open a PR for this update in about a week, unless if anyone else would be interested in tackling it.

[AyushDharDubey]

A possible low-tech solution: agree on a tag for flawed models. Admins can add the tag where necessary and users can ignore models with that tag.

That would indeed be the easiest way forward and would work well for new models. However, for models already in use, it would mean going back and manually replacing them on every renderer they’re already in use.

I’d propose to have a sort of laid down rule as to when a model is reported/found to be flawed, as @tordanik already mentioned, the first step should be to contact the original author and request that they fix the model. With the new OSM profile hyperlinks, it’s now possible to send private messages to users via their OSM profile.

If no response is received within a reasonable timeframe (say, one week), then an admin may step in. At that point, the model can be overwritten by the admin, and it should be labeled as jointly authored to reflect the intervention.

This would ensure consistency in the model_id.

Since admin rights are rightly controlled, this process should ensure fair use of the privilege.