Use Mopidy API directly

[ndarilek]

I'm struggling a bit with some aspects of this as implemented:

• If I say an exact song name, it often doesn't get played.
• The playlists seem a bit arbitrary. If I say "Play ", for instance, I hear the same album by that band, but I have lots of their albums and the choice of which gets played feels arbitrary.
• I don't know how to target specific songs or albums. Further, if an album and song are named the same thing, I don't know of an easy way to disambiguate them.
• It isn't clear that updating the Mopidy library would propagate those changes to Mycroft without a restart, or at the very least a refresh of this skill.

Would you accept a PR that does the following?

• Ports the existing functionality to Mopidy's Python API.
• Creates intents for playback, with optional selection of specific songs/albums (I.e. "Play the album Torn by Evergrey" to specify searches of the library.)

I'm happy to do the work, I just figure there's a reason you scrape the library and create intents manually. Maybe it's so fuzzy text searches can work, but if so I wonder how much of a performance hit it is to fetch the data each time and search that?

Thanks.

[forslund]

Hi,

I'd be happy to accept something like that. This skill was basically the first skill I made for mycroft and it uses Adapt in a way that makes the play intents very restrictive. I.e the artist/album/genre is scraped and generates vocab. Which is good in theory but makes it a bit tricky to activate. It's worked ok for me but I have don't have a very large library.

I've have started on a couple of much needed updates to the skill but no major overhaul as you suggest.

Looking forward to your PR. Let me know if you need to bounce any ideas or if you want to split up the work.

[ndarilek]

Hmm, that was short-lived. Mopidy doesn't run under Python 3. Neither does python-mpd. So it looks like we'll be using the custom client for now. I'll see what I can do with the existing client library and a few intents with slots for album/artist/track.