Frequent freezes

[ostef]

I've been getting frequent freezes (5-10 seconds) for a while now. They happen usually after I compile and launch my project (I use a separate terminal for that) and I come back to Focus.

I can't really tell much about this freeze since I don't really do anything for it to happen other than compile my project, so my guess is it has to do with file system changes.

I guess to find out what's going on we could add instrumentation and log a message when we find a block of code that took multiple seconds to execute?

I am on Windows 10

[focus-editor]

If it's possible to reproduce that consistently, would you be able to run a debug version of the editor in a profiler like Very Sleepy, reproduce a freeze and tell where the time went?

I haven't seen a single freeze like that, which would make hunting down the problem very difficult.

[ostef]

I will do my best to find the source of the freeze and get back to you when I do

[MazyModz]

I am also having ~8 second freezes when I build a project with 100% repro rate. It's an unreal engine project + engine source which is very large with many files. I don't have a debug version of the editor or jai beta access but a trace seems to confirm this is related to windows file manipulation. Of course I can't tell what the function signature is since I don't have the debug symbols so I can only guess that something is causing focus to reload the workspace files during the build?

The function at 0x15052b is responsible for the stalls. All it does is Open,Close,Read files and attributes thousands of times.

When I first load the project all the files are read on a worker thread, but when building it seems to do all of this on the main thread which is causing the stall.

There is also a second or so when the editor becomes responsive again. But it keeps stalling again because it calls 0x15052b again a few frames later and this keeps happening until the build completed.

This is on the lastest release version 0.3.7 on windows

[focus-editor]

@MazyModz I'm not familiar with Unreal but my guess is that it could be writing into files during the build, which would trigger the file watcher to update them in Focus, which we do on the main thread.
Could you please try adding some folders to the ignore list and see if it helps?

[MazyModz]

@focus-editor It marks source files as read-only during compilation but I don't think it writes into them. It does write some metadata files and the binaries into a folder that I have in my ignore list.

If I exclude the Engine Plugins folder from [[workspace]], the stall is only ~0.5s at most. The Plugins folder has many subfolders which contain source, metadata and binaries. But the metadata and binary folder names which the build would write to are already in my ignore list. It's possible it just contains too many source files for the editor to handle, or that changes to files in [ignore] triggers a reload for some reason

[focus-editor]

Please can you try the latest nightly build from https://ileonte.dev/focus-builds/ and tell us if it's any better there? Many bugs were fixed since 0.3.7.

…

On Sat, Jan 18, 2025, 2:16 AM MazyModz ***@***.***> wrote: @focus-editor <https://github.com/focus-editor> It marks source files as read-only during compilation but I don't think it writes into them. It does write some metadata files and the binaries into a folder that I have in my ignore list. If I exclude the Engine Plugins folder from [[workspace]], the stall is only ~0.5s at most. The Plugins folder has many subfolders which contain source, metadata and binaries. But the metadata and binary folder names which the build would write to are already in my ignore list. It's possible it just contains too many source files for the editor to handle, or that changes to files in [ignore] triggers a reload for some reason — Reply to this email directly, view it on GitHub <#472 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4OX77TYQ4YNGQBPGP3FWP32LD7DPAVCNFSM6AAAAABSVMRRNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJYGM2DQMBSGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[MazyModz]

I tired focus-nightly-b8b5d1f and unfortunately the issue persists

[focus-editor]

Would you be willing to help us check where the time went if we sent you a debug build?

FYI you've tried the oldest nightly, the newest one is this https://ileonte.dev/focus-builds/Windows/nightly/focus-nightly-fa1be09.exe

[MazyModz]

I tried the latest and it also has this issue. I'd be willing to help profile a debug build

[focus-editor]

@MazyModz thanks, please can you try this debug build focus.zip

[MazyModz]

@focus-editor

[focus-editor]

Hmm interesting, it's not what I expected at all. This could be because it's an unoptimized build. Please could you also try with this release build with a .pdb file, just to make sure we get the correct information. Thanks!

focus.zip

[MazyModz]

@focus-editor Sure

VirualAlloc

File I/O

Unreal has a lot of directories and there are probably more directories than files in the Plugins folder, each directory seems to be opened. Even directories such as Content and Intermediate which I have in my ignore list.

[focus-editor]

Thanks so much for your help. We're busy at the moment because there's a lot of stuff to do and a new release is overdue, but we'll get to this issue as soon as we can.

The profiling information you've shared is very helpful, we'll optimize workspace scanning using it. There should be a way to avoid allocating as much.

However the real issue is that with Unreal we seem to be getting a lot of file watcher events, we'll have to look closer at the file watcher events we receive when you do a build.