Problems with notifications to posts subscribers on TYPO3 12

[srchild]

On TYPO3 13 with t3extblog 9.0 posts notifications are working immediately after install (after including TypoScript and setting constants, and subscribing an email address).

On TYPO3 12.4.31 and 12.4.32, with t3extblog 8.0.2, it doesn't work. The backend button to send emails doesn't show.

Am I missing some configuration, or does it not work in 12.4.32/8.0.2

Thanks

[fnagel]

Sorry for the late response. I was on vacation and not able to have a look.

It should work in TYPO3 v12 / T3Extblog 8.x too. Include all needed TypoScript and check if settings.subscriptionManager.blog.subscriber.enableNotifications is enabled.

Is it a fresh installation of the plugin or did you upgrade from an earlier version?

[srchild]

It is a fresh installation.

settings.subscriptionManager.blog.subscriber.enableNotifications is set to 1, and that is confirmed when I look at the 'Active TypoScript'

In TYPO3 13 I see a little envelope icon at the right end of the Post in the Dashboard listing, but that does not appear in TYPO3 12, whether 'Notification mails already sent' is ticked or unticked. There isn't even space at the end of the row for an envelope icon to appear, as though perhaps a table cell or column of content is missing just there.

Feel free to suggest any debugging that I could try to help resolve this.

Thanks

[fnagel]

In TYPO3 13 I see a little envelope icon at the right end of the Post in the Dashboard listing

It should be visible in the last cell in the blog post list view in the backend module. Screenshot (v13, as I don't have a proper v12 dev environment ready):

You could debug directly in the template using <f:debug>{_all}</f:debug>. Add it before this block:
https://github.com/fnagel/t3extblog/blob/typo3-12/Resources/Private/Templates/BackendPost/Index.html#L42-L53

Check if the TS settings look good and if the post is suitable for sending.

[srchild]

If I try debugging {_all} TYPO3 crashes with out of memory error (even if I set allowed memory to 750Mb)

I tried

<f:debug>{settings.subscriptionManager.blog.subscriber.enableNotifications}</f:debug>

That gives NULL (twice, I have two test posts)

In Constants on my root page I have

plugin.tx_t3extblog.settings.subscriptionManager.blog.subscriber.enableNotifications = 1

And 'Active Typoscript' confirms the value is 1

Anyway I think 1 is the default value set in the included Blogsystem.typoscript, so even omitting that setting shouldn't stop it working?

If I remove the condition on line 42 then the envelope icons appear and it all works as expected.

Is there something stopping the settings value being passed to the Fluid template??

Thanks

[fnagel]

Very strange that you don't get the TS settings in the template you see in the BE module. Is there any TS at all? Can you try just to debug the settings variable? How do you include the TS?

Anyway I think 1 is the default value set in the included Blogsystem.typoscript, so even omitting that setting shouldn't stop it working?

Unsure, but you should investigate why TS is not available as it could cause other issues with the blog.

In Constants on my root page I have
plugin.tx_t3extblog.settings.subscriptionManager.blog.subscriber.enableNotifications = 1

There is no constant with that path (see available constants here: https://github.com/fnagel/t3extblog/blob/typo3-12/Configuration/TypoScript/constants.typoscript). Please keep in mind: not every TS settings has a corresponding constant!

[srchild]

It does seem likely that there is some problem with my configuration but I haven't tracked it down yet!

I will experiment some more.

Thanks

[srchild]

I've done some more tests and it really seems that {settings} is not being passed to the Fluid template

I simplified my configuration

I stopped loading the TS via my site package and included the default TS in the standard way, under Include TypoScript sets on the Advanced tab of Edit Typoscript Record on my root page.

To keep it simple I loaded only the default TS, not the bootstrap templates or anything else.

I put your suggested initial TS on the root page template setup.

plugin.tx_t3extblog {
	settings {
		blogsystem {
			posts {
				paginate {
					insertAbove = 1
					maximumNumberOfLinks = 1
				}
			}
			comments {
				allowedUntil = +5 years
				approvedByDefault = 1
				subscribeForComments = 0
			}
		}
	}
}
plugin.tx_t3extblog.settings.subscriptionManager.blog.subscriber.enableNotifications = 1
module.tx_t3extblog < plugin.tx_t3extblog

I set a few constants

plugin.tx_t3extblog.settings.blogName = My Blog
plugin.tx_t3extblog.settings.blogsystem.pid = 788
plugin.tx_t3extblog.settings.subscriptionManager.pid = 792
plugin.tx_t3extblog.persistence.storagePid = 789
plugin.tx_t3extblog.settings.emailFrom = me@example.org
plugin.tx_t3extblog.settings.emailTo = alsome@example.org
plugin.tx_t3extblog.settings.privacyPolicy.typolink = 374
plugin.tx_t3extblog.settings.privacyPolicy.enabled = 1

My blog works. The two test posts display properly. Their checkbox 'Notification mails already sent' is not checked but there is no envelope icon

<f:debug>{settings}</f:debug> inserted at line 42 gives null

<f:debug>{post}</f:debug> gives a proper Extbase variable dump

<f:debug>{paginator}</f:debug> inserted near the top also gives a proper Extbase variable dump

If I do the same thing on my TYPO3 13 then debugging {settings} at line 42 works as expected

Any suggestions??

Thanks

[srchild]

I've made a clean installation on a spare domain of TYPO3 12.4.33 with Introduction package and t3extblog. I've used PHP 8.1 (but have also tested with 8.2 and 8.3)

I've done the basic configuration and created a test post which displays ok.

I've checked the configuration of settings.subscriptionManager.blog.subscriber.enableNotifications by looking in 'Active typoscript'

I've subscribed one email to post notifications.

Still the envelope icon does not appear.

I've inserted at line 42

<f:debug>{settings}</f:debug>

Result is as this image

It seems that {settings} is completely empty

Not only is it lacking the enableNotifications but also lacking other settings such as settings.backend.posts.paginate.insertAbove. That appears to default to 0 but if I set it to 1 then still it does not show either in {settings} or {settings.backend.posts.paginate.insertAbove}

I thought that {settings} was passed to Fluid by default, but somehow it seems to be becoming unset or not passed in this case??

[srchild]

If I debug a Frontend template such as Post/Show.html then {settings} appear as expected, confirming that there are values set.

I've never authored any backend modules, but looking at the documentation today I'm uncertain that {settings} are automatically passed to BE templates like they are for FE templates - I've not found that statement anywhere. Is it the case?

Looking at BackendPostController.php you appear to pass settings.backend.posts.paginate explicitly, but even that isn't showing when I debug {settings} in the BE (but does show in the FE debug output above)

    /**
     * Displays posts.
     */
    public function indexAction(int $page = 1): ResponseInterface
    {
        return $this->paginationHtmlResponse(
            'Post/Index',
            $this->postRepository->findByPage($this->pageId, false),
            $this->settings['backend']['posts']['paginate'],
            $page
        );
    }

If I debug the above function

debug($this->settings['backend']['posts']['paginate']);

Also

debug($this->settings);

both show all the settings expected

The correct values are there, so why do they appear not to reach the template {settings}??

[srchild]

Progress!

If I downgrade to either 8.0.0 or 8.0.1 then it works. The envelope icon appears, and also debugging {settings} works as expected.

When I upgrade back to 8.0.2 it stops working again. It seems that something went wrong between 8.0.1 and 8.0.2.

[srchild]

Found it.

In 8.0.2 AbstractBckendController.php initializeView is lacking settings

    /**
     * Initializes the view before invoking an action method.
     */
    protected function initializeView()
    {
        $dateTimeFormat = $GLOBALS['TYPO3_CONF_VARS']['SYS']['ddmmyy'].' '.$GLOBALS['TYPO3_CONF_VARS']['SYS']['hhmm'];
        if (!empty($this->settings['backend']['dateTimeFormat'])) {
            $dateTimeFormat = trim($this->settings['backend']['dateTimeFormat']);
        }

        $this->moduleTemplate = $this->moduleTemplateFactory->create($this->request);

        $this->moduleTemplate->assignMultiple([
            'pageId' => $this->pageId,
            'dateTimeFormat' => $dateTimeFormat,
            'pageNotice' => $this->pageInfo,
        ]);

Fix by adding an extra line to assignMultiple

     * Initializes the view before invoking an action method.
     */
    protected function initializeView()
    {
        $dateTimeFormat = $GLOBALS['TYPO3_CONF_VARS']['SYS']['ddmmyy'].' '.$GLOBALS['TYPO3_CONF_VARS']['SYS']['hhmm'];
        if (!empty($this->settings['backend']['dateTimeFormat'])) {
            $dateTimeFormat = trim($this->settings['backend']['dateTimeFormat']);
        }

        $this->moduleTemplate = $this->moduleTemplateFactory->create($this->request);

        $this->moduleTemplate->assignMultiple([
            'pageId' => $this->pageId,
            'dateTimeFormat' => $dateTimeFormat,
            'pageNotice' => $this->pageInfo,
            'settings' => $this->settings,
         ]);

Not yet thoroughly tested, but looking good

[fnagel]

I stopped loading the TS via my site package and included the default TS in the standard way, under Include TypoScript sets on the Advanced tab of Edit Typoscript Record on my root page.

Including via a sitepacke extension is fine, I've configured the blog since years like that. Switched to site sets in v13 tough.

I thought that {settings} was passed to Fluid by default, but somehow it seems to be becoming unset or not passed in this case??

Fluid behaves differently in the backend, but yes, this should be the case. At least until v12, since v13 its no longer injected, see 3fcc1b9

I've made a clean installation on a spare domain of TYPO3 12.4.33 with Introduction package and t3extblog. I've used PHP 8.1 (but have also tested with 8.2 and 8.3)

Oh wow, you did some really intense testing here! Anyway, I don't think its related to the PHP version but a more general issue with the TS inclusion or a real bug (which is unlikely, as it worked for me and others without issues in TYPO3 v12).

Looking at BackendPostController.php you appear to pass settings.backend.posts.paginate explicitly, but even that isn't showing when I debug {settings} in the BE (but does show in the FE debug output above)

The paginationHtmlResponse method is a helper method which creates the needed pagination classes and passed it to the template. The actual settings.backend.posts.paginate values are not passed, see:
https://github.com/fnagel/t3extblog/blob/8.x/Classes/Controller/AbstractBackendController.php#L228-L243

If I downgrade to either 8.0.0 or 8.0.1 then it works.

Ok, so we need to find the bug in this diff:
8.0.1...8.0.2

The module configuration has been updated to match the (again and again) changed BE module functionality, see here:
3cfe6e8

It's definitely possible it's needed to inject the settings manually as I needed to add it for v13 too (see above), but I was not able to find any reference or changelog explaining this. Anyway, injecting the settings will not break anything so we might just do it.

Any more feedback from your testing? Does everything work?
Are you willing to create a PR for the 8.x branch?