Confirmation dialog for adding/removing namespace prefixes should expect yes/no answers instead of Cancel/Apply

[jgomo3]

In the Browser (left vertical pane), after selecting "Add instr prefix for .*" for a namespace, appears a confirmation dialog asking if

Do you want FlowStorm to reload all namespaces that matches #"^.*" so the instrumentation changes take effect?
Providing the options to "Cancel" or "Apply".

Notice that the intrumentation prefix was already added.

This dialog is not meant to confirm "Add(ing) instr prefix for .*". The moment you click that, it happens, the prefix is already added. The dialog is actually meant to control a different new action, explained in the dialog text itself: "to reload all namespaces that matches ".

Besides the confussion of expecting the dialog to prevent/control the action I just "clicked" (Add instr prefix), but instead it does something else (asking you to perform a new action), the options to answer the question are also missleading. When being asked if one wants to perform a new action, one would expect to answer "Yes" or "No", not "Cancel" or "Apply".

So I suggest for a quick fix to change the text of the Responses from "Cancel/Apply" to "Yes/No".

Alternativelly, you might want to:

• Default to "Add instr prefix and Reload all namespaces matching" with the possibility to Opt out somehow
• Or to present two options when "right" clicking the namespace you want an instrumentation prefix to be add to:
  • Add instr prefix for .* (Reloading all namespaces matching)
  • Add instr prefix for .* (Not reloading any namespace)

You might want or not to add a Confirmation-with-warning action for Reloading and/or not Reloading. I would add the dialog with a checkbox option for not showing the Confirmation-warning ever again.

Finally, if this change is applied, don't forget to update the Tutorial (2/9).

Notice this also happens when one tries to delete a prefix.

[jpmonettas]

Hi @jgomo3 ! Thanks for the feedback!

I agree that the options for answering that question should be Yes/No, will change that.

There is no cancellation alert for adding/removing prefixes since they are harmless and easy reversible, but maybe it should be for the removing one.

I don't find super confusing the system asking for reloading the namespaces after you changed something instrumentation related. In my mind is like when you change some important setting on a system and it immediately prompts you if you want to restart the system for the changes to take effect, or for whatever reason you are going to do it later by yourself.