[Feature] Create Custom Conversion Columns in Final Report models

[markloomis32]

Is there an existing feature request for this?

• I have searched the existing issues

Describe the Feature

Create the ability to create custom conversion columns that persist in the downstream models. The columns would be defined based on the action_type field in the stg_facebook_ads__basic_ad_actions.

Example
Custom Conversion of lead

sql definition

Select 
    action_type,
    sum(conversions) as leads
FROM `inq-warehouse.analytics.stg_facebook_ads__basic_ad_actions` 
where action_type = 'lead'
group by 1

How would you implement this feature?

The implementation could be similar to the other vars: variable setup in the package. Custom leads are defined by vars with name, alias, and sql criteria.

Describe alternatives you've considered

custom sql models

Are you interested in contributing this feature?

• Yes.
• Yes, but I will need assistance.
• No.

Anything else?

discussion with Jamie Rodriguez from Fivetran in the dbt slack

[fivetran-savage]

Hi @markloomis32! Thank you so much for bringing this to our attention. I wanted to let you know that we've brought this into our current sprint and I'll be the one handling the work. Because you answered "Yes" to the "Are you interested in contributing this feature," I wanted to check in before getting started. If you don't have capacity or are no longer interested, no worries at all, we are going to incorporate this feature into our next release regardless. But if you are still interested, you are welcome to create a branch and open a PR, which I will review and then merge into a release branch once any needed adjustments are made. Please let me know if you have additional questions or would like a more detailed walk-through of the contribution process. I'm going to start work on this Monday afternoon or Tuesday morning.

[markloomis32]

@fivetran-savage Great News! I don't think i would be able to help contribute until mid-January so i think it is a no. If the change is adapted to the other ad models (google ads, etc) - perhaps I could contribute to that?

[fivetran-savage]

@markloomis32 completely understandable. Thanks again for bringing this up and I'll be in touch if/when we make this type of update to additional ad models. Enjoy the holidays!