Skip to content

Commit 6e6ab66

Browse files
Update freshness config (#51)
* Update freshness config * replace dbt 1.9.5 with 1.9.6 * source package ref
1 parent 12e6369 commit 6e6ab66

6 files changed

Lines changed: 60 additions & 28 deletions

File tree

Lines changed: 29 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,35 @@
1-
## PR Overview
2-
**This PR will address the following Issue/Feature:**
1+
<!--
2+
Pre-Submission Reminders
3+
Before marking this PR as "ready for review":
34
4-
**This PR will result in the following new package version:**
5-
<!--- Please add details around your decision for breaking vs non-breaking version upgrade. If this is a breaking change, were backwards-compatible options explored? -->
5+
- `dbt run --full-refresh && dbt test`
6+
- `dbt run` && `dbt test` (if incremental models are present)
7+
- The related issue is linked, tagged, and appropriately assigned
8+
- Documentation and version updates are included, if applicable
9+
- `docs` have been regenerated (unless there are no code or YAML changes)
10+
- BuildKite integration tests are passing
11+
-->
612

7-
**Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:**
8-
<!--- Copy/paste the CHANGELOG for this version below. -->
13+
## PR Overview
14+
**Package version introduced in this PR:**
15+
16+
**This PR addresses the following Issue/Feature(s):**
17+
<!-- Add Issue # or internal ticket reference -->
918

10-
## PR Checklist
11-
### Basic Validation
12-
Please acknowledge that you have successfully performed the following commands locally:
13-
- [ ] dbt run –full-refresh && dbt test
14-
- [ ] dbt run (if incremental models are present) && dbt test
19+
**Summary of changes:**
20+
<!-- 1-2 sentences describing PR changes. -->
1521

16-
Before marking this PR as "ready for review" the following have been applied:
17-
- [ ] The appropriate issue has been linked, tagged, and properly assigned
18-
- [ ] All necessary documentation and version upgrades have been applied
19-
- [ ] docs were regenerated (unless this PR does not include any code or yml updates)
20-
- [ ] BuildKite integration tests are passing
21-
- [ ] Detailed validation steps have been provided below
2222

23-
### Detailed Validation
24-
Please share any and all of your validation steps:
25-
<!--- Provide the steps you took to validate your changes below. -->
23+
### Submission Checklist
24+
- [ ] Alignment meeting with the reviewer (if needed)
25+
- [ ] Timeline and validation requirements discussed
26+
- [ ] Provide validation details:
27+
- [ ] **Validation Steps:** Check for unintentional effects (e.g., add/run consistency & integrity tests)
28+
- [ ] **Testing Instructions:** Confirm the change addresses the issue(s)
29+
- [ ] **Focus Areas:** Complex logic or queries that need extra attention
2630

27-
### If you had to summarize this PR in an emoji, which would it be?
28-
<!--- For a complete list of markdown compatible emojis check our this git repo (https://gist.github.com/rxaviers/7360908) -->
29-
:dancer:
31+
### Changelog
32+
<!-- Recommend drafting changelog notes, then refining via ChatGPT using:
33+
"Draft a changelog entry based on the following notes." -->
34+
- [ ] Draft changelog for PR
35+
- [ ] Final changelog for release review

CHANGELOG.md

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,29 @@
1+
# dbt_facebook_ads v0.10.0
2+
3+
[PR #51](https://github.com/fivetran/dbt_facebook_ads/pull/51) introduces the following updates:
4+
5+
## Breaking Change for dbt Core < 1.9.6
6+
> *Note: This is not relevant to Fivetran Quickstart users.*
7+
8+
Migrated `freshness` from a top-level source property to a source `config` in alignment with [recent updates](https://github.com/dbt-labs/dbt-core/issues/11506) from dbt Core ([Source PR #45](https://github.com/fivetran/dbt_facebook_ads_source/pull/45)). This will resolve the following deprecation warning that users running dbt >= 1.9.6 may have received:
9+
10+
```
11+
[WARNING]: Deprecated functionality
12+
Found `freshness` as a top-level property of `facebook_ads` in file
13+
`models/src_facebook_ads.yml`. The `freshness` top-level property should be moved
14+
into the `config` of `facebook_ads`.
15+
```
16+
17+
**IMPORTANT:** Users running dbt Core < 1.9.6 will not be able to utilize freshness tests in this release or any subsequent releases, as older versions of dbt will not recognize freshness as a source `config` and therefore not run the tests.
18+
19+
If you are using dbt Core < 1.9.6 and want to continue running Facebook Ads freshness tests, please elect **one** of the following options:
20+
1. (Recommended) Upgrade to dbt Core >= 1.9.6
21+
2. Do not upgrade your installed version of the `facebook_ads` package. Pin your dependency on v0.9.0 in your `packages.yml` file.
22+
3. Utilize a dbt [override](https://docs.getdbt.com/reference/resource-properties/overrides) to overwrite the package's `facebook_ads` source and apply freshness via the [old](https://github.com/fivetran/dbt_facebook_ads_source/blob/v0.9.0/models/src_facebook_ads.yml#L11-L13) top-level property route. This will require you to copy and paste the entirety of the `src_facebook_ads.yml` [file](https://github.com/fivetran/dbt_facebook_ads_source/blob/v0.9.0/models/src_facebook_ads.yml#L4-L374) and add an `overrides: facebook_ads_source` property.
23+
24+
## Under the Hood
25+
- Updated the package maintainer PR template.
26+
127
# dbt_facebook_ads v0.9.0
228

329
[PR #50](https://github.com/fivetran/dbt_facebook_ads/pull/50) introduces the following updates:

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ Include the following facebook_ads package version in your `packages.yml` file:
6969
```yml
7070
packages:
7171
- package: fivetran/facebook_ads
72-
version: [">=0.9.0", "<0.10.0"] # we recommend using ranges to capture non-breaking changes automatically
72+
version: [">=0.10.0", "<0.11.0"] # we recommend using ranges to capture non-breaking changes automatically
7373
```
7474

7575
Do NOT include the `facebook_ads_source` package in this file. The transformation package itself has a dependency on it and will install the source package as well.
@@ -213,7 +213,7 @@ This dbt package is dependent on the following dbt packages. These dependencies
213213
```yml
214214
packages:
215215
- package: fivetran/facebook_ads_source
216-
version: [">=0.9.0", "<0.10.0"]
216+
version: [">=0.10.0", "<0.11.0"]
217217
218218
- package: fivetran/fivetran_utils
219219
version: [">=0.4.0", "<0.5.0"]

dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'facebook_ads'
2-
version: '0.8.1'
2+
version: '0.10.0'
33
config-version: 2
44
require-dbt-version: [">=1.3.0", "<2.0.0"]
55
models:

integration_tests/dbt_project.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'facebook_ads_integration_tests'
2-
version: '0.9.0'
2+
version: '0.10.0'
33
profile: 'integration_tests'
44
config-version: 2
55

packages.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
packages:
22
- package: fivetran/facebook_ads_source
3-
version: [">=0.9.0", "<0.10.0"]
3+
version: [">=0.10.0", "<0.11.0"]

0 commit comments

Comments
 (0)