Open
Conversation
1bc0aef to
2f7fb1c
Compare
f95d2a4 to
2c54e72
Compare
8e60163 to
26113d8
Compare
cce6efc to
fdefbbd
Compare
ec7e65c to
6868df5
Compare
e03a7a7 to
572af82
Compare
rckirby
requested changes
Aug 26, 2025
rckirby
left a comment
There was a problem hiding this comment.
I like the speedup and reduced dependency on sympy. I have a few questions
41a0a71 to
0799365
Compare
0799365 to
3225043
Compare
e3a2eef to
4d00815
Compare
pbrubeck
commented
Aug 28, 2025
e4b1ce9 to
2b5eb2a
Compare
86d4464 to
c61b8e7
Compare
f9664f9 to
774e698
Compare
774e698 to
d3bdf9d
Compare
4293cbe to
166ad2c
Compare
…/fiat into pbrubeck/gem-tabulation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tabulate unknown points directly to gem, as opposed to first tabulating to sympy.
The gem-only approach is significantly faster: