Skip to content

feat: add Intl.NumberFormat to number helpers #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertkibet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add Intl.NumberFormat to number helpers #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions global/helpers/numbers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,19 @@ export const adjustValueToStep = (value: number, step: number, precision?: numbe

return setDecimalPrecision(floor, precision);
};

/**
* Format number to international locale string or fallback to default browser locale
* @param number - number to format
* @param locale - locale to format number to
* @returns formatted number
*/
export const formatNumber = (number: number, locale?: string) => {
if (!Intl.NumberFormat || !number || !navigator.language) return number;

const browserLocale = navigator.language;

const formatter = new Intl.NumberFormat(locale || browserLocale);

return Number(formatter.format(number));
};
4 changes: 2 additions & 2 deletions packages/readtime/src/factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { getInstanceIndex } from '$global/helpers';
import { formatNumber, getInstanceIndex } from '$global/helpers';

import { ATTRIBUTES, DEFAULT_WPM, queryElement } from './utils/constants';

Expand All @@ -20,5 +20,5 @@ export const initReadTime = (timeElement: Element) => {

const readTime = wordsCount / wpm;

timeElement.textContent = !decimals && readTime < 0.5 ? '1' : readTime.toFixed(decimals);
timeElement.textContent = readTime < 0.5 ? '1' : formatNumber(readTime).toFixed(decimals);
};