Skip to content

Commit 3ffb01e

Browse files
kraki24MrChromebox
authored andcommitted
mb/siemens/mc_rpl1: Disable I2C1 and enable I2C6
Reconfigure I2C controller settings to disable I2C1 and enable I2C6 for the mc_rpl1 mainboard. This change reflects the updated hardware configuration requirements. Changes: - Disable I2C controller 1 - Enable I2C controller 6 TEST=Build and boot tested on mc_rpl1 mainboard. Verified I2C6 functionality and confirmed I2C1 is disabled with `lspci -v | grep -A 5 "Serial bus controller"`. The output confirms that I2C6 (PCI 00:10.0) is enabled and I2C1 (PCI 00:15.1) is disabled because it is absent. ``` 00:10.0 Serial bus controller: Intel Corporation Alder Lake-P Serial IO I2C Controller #2 (rev 01) Subsystem: Intel Corporation Alder Lake-P Serial IO I2C Controller Flags: bus master, fast devsel, latency 0, IRQ 24, IOMMU group 4 Memory at 80a12000 (64-bit, non-prefetchable) [size=4K] Capabilities: [80] Power Management version 3 Capabilities: [90] Vendor Specific Information: Len=14 <?> ``` Change-Id: I4867062743ee10b34f94a1e588a10115b553a16e Signed-off-by: Kilian Krause <kilian.krause@siemens.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/89690 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Uwe Poeche <uwe.poeche@siemens.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
1 parent 4563db2 commit 3ffb01e

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

src/mainboard/siemens/mc_rpl/variants/mc_rpl1/gpio.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ static const struct pad_config gpio_table[] = {
3030
PAD_CFG_GPI(GPP_H1, NONE, PLTRST),
3131
PAD_CFG_GPI(GPP_H2, NONE, PLTRST),
3232
PAD_CFG_NF(GPP_H3, NONE, DEEP, NF1),
33-
PAD_CFG_NF(GPP_H6, NONE, DEEP, NF1), /* I2C1_SDA */
34-
PAD_CFG_NF(GPP_H7, NONE, DEEP, NF1), /* I2C1_SCL */
3533
PAD_CFG_NF(GPP_H10, NONE, DEEP, NF2), /* UART0_RXD */
3634
PAD_CFG_NF(GPP_H11, NONE, DEEP, NF2), /* UART0_TXD */
3735
PAD_CFG_NF(GPP_H19, NONE, DEEP, NF1), /* PCIE_XCLKREQ4 */
@@ -44,6 +42,8 @@ static const struct pad_config gpio_table[] = {
4442
PAD_CFG_NF(GPP_D8, NONE, DEEP, NF1), /* PCIE_XCLKREQ3 */
4543
PAD_CFG_GPI(GPP_D10, NONE, PLTRST),
4644
PAD_CFG_GPI(GPP_D12, NONE, PLTRST),
45+
PAD_CFG_NF(GPP_D13, NONE, DEEP, NF3), /* I2C6_SDA */
46+
PAD_CFG_NF(GPP_D14, NONE, DEEP, NF3), /* I2C6_SCL */
4747
PAD_CFG_NF(GPP_D17, NONE, DEEP, NF1), /* UART1_RXD */
4848
PAD_CFG_NF(GPP_D18, NONE, DEEP, NF1), /* UART1_TXD */
4949

src/mainboard/siemens/mc_rpl/variants/mc_rpl1/overridetree.cb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,12 @@ chip soc/intel/alderlake
4242

4343
register "serial_io_i2c_mode" = "{
4444
[PchSerialIoIndexI2C0] = PchSerialIoPci,
45-
[PchSerialIoIndexI2C1] = PchSerialIoPci,
45+
[PchSerialIoIndexI2C1] = PchSerialIoDisabled,
4646
[PchSerialIoIndexI2C2] = PchSerialIoDisabled,
4747
[PchSerialIoIndexI2C3] = PchSerialIoDisabled,
4848
[PchSerialIoIndexI2C4] = PchSerialIoDisabled,
4949
[PchSerialIoIndexI2C5] = PchSerialIoDisabled,
50+
[PchSerialIoIndexI2C6] = PchSerialIoPci,
5051
}"
5152

5253
register "serial_io_uart_mode" = "{
@@ -60,7 +61,7 @@ chip soc/intel/alderlake
6061
.i2c[0] = {
6162
.speed = I2C_SPEED_FAST,
6263
},
63-
.i2c[1] = {
64+
.i2c[6] = {
6465
.speed = I2C_SPEED_FAST,
6566
},
6667
}"
@@ -119,7 +120,7 @@ chip soc/intel/alderlake
119120
}"
120121
end
121122
device ref i2c0 on end
122-
device ref i2c1 on end
123+
device ref i2c6 on end
123124
device ref xhci on
124125
chip drivers/usb/acpi
125126
register "desc" = ""Root Hub""

0 commit comments

Comments
 (0)