Skip to content

Support uppercase mp3 and mp4 tags #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaykitty wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support uppercase mp3 and mp4 tags #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions sync_music/replaygain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@
logger = logging.getLogger(__name__) # pylint: disable=invalid-name


def get_tag(tags, *tag_names):
"""Check if a file has on of the given tags"""
for tag_name in tag_names:
if tag_name in tags.keys():
return tags[tag_name]
raise KeyError


class ReplayGain:
"""ReplayGain information"""

Expand Down Expand Up @@ -62,18 +70,30 @@ def from_tags(cls, in_filepath, album_gain=False):
tag_type = "album" if album_gain else "track"
try:
if isinstance(in_file, mutagen.mp3.MP3):
gain = in_file.tags[f"TXXX:replaygain_{tag_type}_gain"].text[0]
peak = in_file.tags[f"TXXX:replaygain_{tag_type}_peak"].text[0]
gain = get_tag(
in_file.tags,
f"TXXX:replaygain_{tag_type}_gain",
f"TXXX:REPLAYGAIN_{tag_type.upper()}_GAIN",
).text[0]
peak = get_tag(
in_file.tags,
f"TXXX:replaygain_{tag_type}_peak",
f"TXXX:REPLAYGAIN_{tag_type.upper()}_PEAK",
).text[0]
elif isinstance(in_file, (mutagen.flac.FLAC, mutagen.oggvorbis.OggVorbis)):
gain = in_file.tags[f"replaygain_{tag_type}_gain"][0]
peak = in_file.tags[f"replaygain_{tag_type}_peak"][0]
gain = get_tag(in_file.tags, f"replaygain_{tag_type}_gain")[0]
peak = get_tag(in_file.tags, f"replaygain_{tag_type}_peak")[0]
elif isinstance(in_file, mutagen.mp4.MP4):
gain = in_file.tags[
f"----:com.apple.iTunes:replaygain_{tag_type}_gain"
][0].decode("utf-8", "ignore")
peak = in_file.tags[
f"----:com.apple.iTunes:replaygain_{tag_type}_peak"
][0].decode("utf-8", "ignore")
gain = get_tag(
in_file.tags,
f"----:com.apple.iTunes:replaygain_{tag_type}_gain",
f"----:com.apple.iTunes:REPLAYGAIN_{tag_type.upper()}_GAIN",
)[0].decode("utf-8", "ignore")
peak = get_tag(
in_file.tags,
f"----:com.apple.iTunes:replaygain_{tag_type}_peak",
f"----:com.apple.iTunes:REPLAYGAIN_{tag_type.upper()}_PEAK",
)[0].decode("utf-8", "ignore")
else:
return None
return cls(float(gain.replace("dB", "")), float(peak))
Expand Down