-
Notifications
You must be signed in to change notification settings - Fork 8
Closed
Labels
XS effortT-shirt effort weighing: XST-shirt effort weighing: XSenhancementNew feature or requestNew feature or request
Milestone
Description
Summary
Several CPU-bound FairGBM functions are currently single threaded.
TODO:
- Test if everything works correctly when using the following directive on (most) loops over the data:
#pragma omp parallel for schedule(static)- The loop at
ConstrainedObjectiveFunction::GetConstraintGradientsWRTModelOutputshould be the focus, as it is where most CPU time is spent; - AFAIK the loop seems to be parallelizable: no variables seem to be changed in the same location (arrays are changed but always at the position of the given row index, therefore no race conditions should occur);
- If not, adapt the loop such that each thread does not alter variables in common (or use locks when it's impossible to separate the logic);
- The loop at
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
XS effortT-shirt effort weighing: XST-shirt effort weighing: XSenhancementNew feature or requestNew feature or request