Merged
Conversation
This was referenced Apr 10, 2025
18 tasks
johnnyporkchops
approved these changes
Jun 17, 2025
Contributor
johnnyporkchops
left a comment
There was a problem hiding this comment.
Everything works as expected
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6750 +/- ##
========================================
Coverage 79.79% 79.79%
========================================
Files 238 238
Lines 5247 5247
========================================
Hits 4187 4187
Misses 1060 1060 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolving the jQuery deprecations has been a burden so let's break #6411 into much smaller pieces
Required reviewers
Impacted areas of the application
General components of the application that this PR will affect:
click()and.click(𝑓)on/inScreenshots
No changes
Related PRs
Related PRs against other branches:
.click.change.focus,.blur.bind,:first,.hover,.keyCode,:last,.submit,.trim‡you are here
How to test
npm inpm run test-singleshould be clearnpm run build./manage.py runserverclickactions and handlers:feedback boxlink handler should open the feedback boxfeedback boxlink handler should open the feedback boxTabbing to individual events, return/enter should open the pop-upKNOWN ISSUE: doesn't work here or on Production.is-checkedand initially clicking/checking items isn't calling that function at all (i.e. clicking a new item works fine buthandleDropdownItemClick()isn't called