Skip to content

Uncancelled Task on manual toast dismiss in NotificationToastOverlay #217

@fatihkan

Description

@fatihkan

Bug Description

In NotificationToastOverlay.swift:73-79, when a user manually dismisses a toast, the auto-dismiss Task that was spawned continues running. When it fires, it may dismiss a different toast that has since taken the dismissed toast's position.

Location

CreedFlow/Sources/CreedFlow/Views/Notifications/NotificationToastOverlay.swift:73-79

Severity

Important — Wrong toast dismissed after manual dismiss.

Steps to Fix

  1. Store the Task handle per toast
  2. Cancel the Task when the toast is manually dismissed
  3. Check toast identity before auto-dismissing

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingswiftSwift/SwiftUI codev1.7.0Target: v1.7.0 release

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions