Skip to content

Commit 91bccb5

Browse files
authored
Move built-in data appending above custom metrics (#131)
This allows for end users to override built-in metrics
1 parent 964f3ed commit 91bccb5

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

core/src/main/java/dev/faststats/core/SimpleMetrics.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,13 @@ protected JsonObject createData() {
260260
metrics.addProperty("os_name", osName);
261261
metrics.addProperty("os_version", osVersion);
262262

263+
try {
264+
appendDefaultData(metrics);
265+
} catch (final Throwable t) {
266+
error("Failed to append default data", t);
267+
getErrorTracker().ifPresent(tracker -> tracker.trackError(t));
268+
}
269+
263270
this.metrics.forEach(metric -> {
264271
try {
265272
metric.getData().ifPresent(element -> metrics.add(metric.getId(), element));
@@ -269,13 +276,6 @@ protected JsonObject createData() {
269276
}
270277
});
271278

272-
try {
273-
appendDefaultData(metrics);
274-
} catch (final Throwable t) {
275-
error("Failed to append default data", t);
276-
getErrorTracker().ifPresent(tracker -> tracker.trackError(t));
277-
}
278-
279279
data.addProperty("identifier", config.serverId().toString());
280280
data.add("data", metrics);
281281

0 commit comments

Comments
 (0)