From ba1f35d9db13330d0e321cc50889be1266043d36 Mon Sep 17 00:00:00 2001 From: Jerome Lacoste Date: Wed, 29 Nov 2023 20:26:39 +0100 Subject: [PATCH 1/3] Remove stderr from delete-*-password calls --- lib/security/password.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/security/password.rb b/lib/security/password.rb index 49aa39d..759a026 100644 --- a/lib/security/password.rb +++ b/lib/security/password.rb @@ -76,7 +76,7 @@ def find(options) end def delete(options) - system "security delete-generic-password #{flags_for_options(options)}" + system "security delete-generic-password #{flags_for_options(options)} 2>/dev/null" end private @@ -104,7 +104,7 @@ def find(options) end def delete(options) - system "security delete-internet-password #{flags_for_options(options)}" + system "security delete-internet-password #{flags_for_options(options)} 2>/dev/null" end private From 1e9fda59ff2a0997129359c3b2250c162e65ba35 Mon Sep 17 00:00:00 2001 From: Jerome Lacoste Date: Wed, 29 Nov 2023 20:34:42 +0100 Subject: [PATCH 2/3] Also remove standard output from security delete-*-password as it clutters the tests output --- lib/security/password.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/security/password.rb b/lib/security/password.rb index 759a026..7431817 100644 --- a/lib/security/password.rb +++ b/lib/security/password.rb @@ -76,7 +76,7 @@ def find(options) end def delete(options) - system "security delete-generic-password #{flags_for_options(options)} 2>/dev/null" + system "security delete-generic-password #{flags_for_options(options)} 2>&1 >/dev/null" end private @@ -104,7 +104,7 @@ def find(options) end def delete(options) - system "security delete-internet-password #{flags_for_options(options)} 2>/dev/null" + system "security delete-internet-password #{flags_for_options(options)} 2>&1 >/dev/null" end private From ed72ae3a78566ec5786f33c016f2f2a375d682a7 Mon Sep 17 00:00:00 2001 From: Jerome Lacoste Date: Fri, 1 Dec 2023 11:54:27 +0100 Subject: [PATCH 3/3] Use the recommended pattern (bash/zsh) --- lib/security/password.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/security/password.rb b/lib/security/password.rb index 7431817..404b734 100644 --- a/lib/security/password.rb +++ b/lib/security/password.rb @@ -76,7 +76,7 @@ def find(options) end def delete(options) - system "security delete-generic-password #{flags_for_options(options)} 2>&1 >/dev/null" + system "security delete-generic-password #{flags_for_options(options)} >& /dev/null" end private @@ -95,7 +95,6 @@ def add(server, account, password, options = {}) options[:a] = account options[:s] = server options[:w] = password - system "security add-internet-password #{flags_for_options(options)}" end @@ -104,7 +103,7 @@ def find(options) end def delete(options) - system "security delete-internet-password #{flags_for_options(options)} 2>&1 >/dev/null" + system "security delete-internet-password #{flags_for_options(options)} >&/dev/null" end private