fix(bridge): audit_log_appends test fails due to missing setup cleanup

[fagemx]

Problem

bg_detect::tests::audit_log_appends in edda-bridge-claude/src/bg_detect.rs:963 consistently fails:

assertion failed: left=13, right=1

Root Cause

The test only cleans up the audit log file in teardown (end of test), not in setup (start of test). When run multiple times, the audit log file accumulates entries from previous runs, causing the line count assertion to fail.

Fix

Add cleanup at the start of the test:

let _ = fs::remove_file(audit_log_path(pid));

Impact

• CI noise: this test fails on every run after the first
• 5-minute fix

Labels

bug, testing

[fagemx]

Research: fix(bridge) audit_log_appends test cleanup (GH-373)

Problem Statement

bg_detect::tests::audit_log_appends in crates/edda-bridge-claude/src/bg_detect.rs:963 consistently fails after the first run:

assertion failed: left=13, right=1

The test asserts that after one append_audit_log call, the file has exactly 1 line. But stale data from previous runs inflates the count.

Code Analysis

The failing test (line 963-1000)

#[test]
fn audit_log_appends() {
    let pid = "test_detect_audit";
    let _ = edda_store::ensure_dirs(pid);
    // <-- NO cleanup of audit_log_path(pid) here

    let entry = AuditEntry { ... };
    append_audit_log(pid, &entry).unwrap();

    let content = fs::read_to_string(&path).unwrap();
    assert_eq!(content.lines().count(), 1);  // FAILS if file already existed

    append_audit_log(pid, &entry2).unwrap();
    assert_eq!(content2.lines().count(), 2); // Also fails (accumulated)

    // Cleanup only at teardown
    let _ = fs::remove_dir_all(edda_store::project_dir(pid));
}

How sibling tests handle this

Two other tests in the same module correctly clean up at setup:

• should_run_returns_true_when_never_run (line 860): let _ = fs::remove_file(detect_state_path(pid));
• increment_session_count_works (line 944): let _ = fs::remove_file(detect_state_path(pid));

Why teardown cleanup is insufficient

The teardown line (fs::remove_dir_all(...)) uses project_dir(pid), which should remove the entire directory. However:

1. If the test panics (assertion failure), teardown never runs.
2. If another test with the same pid prefix runs concurrently, the directory may be recreated.
3. The project_dir used in cleanup may differ from where audit_log_path actually writes (via state_dir).

Key functions

Function	Location	Purpose
audit_log_path(pid)	line 730	Returns state_dir(pid).join("bg_detect_audit.jsonl")
append_audit_log(pid, entry)	line 766	Appends JSONL line to audit log
state_dir(pid)	line 727	Returns edda_store::project_dir(pid).join("bg_detect")

Conclusion

Root cause is confirmed: missing setup cleanup. The fix is a single line addition at the start of the test.

[fagemx]

Innovation: fix(bridge) audit_log_appends test cleanup (GH-373)

Solution Options

Option A: Add remove_file at test start (Recommended)

Add one line after ensure_dirs:

let _ = fs::remove_file(audit_log_path(pid));

Pros:

• Follows the exact pattern used by sibling tests (increment_session_count_works, should_run_returns_true_when_never_run)
• Minimal change, minimal risk
• Idempotent -- harmless if file doesn't exist

Cons:

• None significant

Option B: Use unique temp directories per test run

Replace the hardcoded pid with a unique value (e.g., format!("test_detect_audit_{}", ulid::Ulid::new())).

Pros:

• Eliminates all cross-run interference by design

Cons:

• Breaks the established pattern used by all other tests in this module
• Leaves orphan directories accumulating over time
• More code for no real benefit on a simple fix

Option C: Use tempfile::tempdir() for test isolation

Pros:

• Auto-cleanup via RAII

Cons:

• Would require restructuring audit_log_path to accept a custom base directory
• Over-engineered for this specific problem
• Not how any other test in this file works

Recommendation

Option A -- single line addition. It matches existing conventions, is proven by sibling tests, and directly addresses the root cause.

[fagemx]

Plan: fix(bridge) audit_log_appends test cleanup (GH-373)

Implementation Steps

Step 1: Add setup cleanup to audit_log_appends test

File: crates/edda-bridge-claude/src/bg_detect.rs
Location: Line 966, after let _ = edda_store::ensure_dirs(pid);

Change: Add one line:

let _ = fs::remove_file(audit_log_path(pid));

The test block becomes:

#[test]
fn audit_log_appends() {
    let pid = "test_detect_audit";
    let _ = edda_store::ensure_dirs(pid);
    let _ = fs::remove_file(audit_log_path(pid));  // <-- NEW: clean slate

    // ... rest unchanged
}

Step 2: Verify

cargo test -p edda-bridge-claude audit_log_appends -- --nocapture
# Run twice to confirm no accumulation
cargo test -p edda-bridge-claude audit_log_appends -- --nocapture

Test Strategy

• Primary: Run audit_log_appends twice in succession -- both must pass.
• Regression: Run cargo test -p edda-bridge-claude to ensure no other tests are affected.
• CI: No CI config changes needed.

Commit

fix(bridge): add setup cleanup to audit_log_appends test

Risk Assessment

• Risk: Minimal. Single line addition following established patterns.
• Blast radius: One test function, no production code changes.
• Rollback: Revert single line.

[fagemx]

Work completed. PR created: #380

All CI checks passing.