From 707fdd676e404baab92f5f2f52c472dab45eb229 Mon Sep 17 00:00:00 2001 From: Ziyan Huang Date: Wed, 10 Aug 2022 23:49:34 -0700 Subject: [PATCH] Remove unrelated API out of container service Summary: We decided that validate_container_definitions should not be a public API in container service. This diff is to remove it and resolve the conflict. Next diff is to move it to util Differential Revision: D38604420 fbshipit-source-id: 5a5006ba085a3d41eeafacc42027d2e44485fb64 --- fbpcp/service/container.py | 8 -------- fbpcp/service/onedocker.py | 4 ---- 2 files changed, 12 deletions(-) diff --git a/fbpcp/service/container.py b/fbpcp/service/container.py index 557a2afb..99b1455a 100644 --- a/fbpcp/service/container.py +++ b/fbpcp/service/container.py @@ -109,11 +109,3 @@ def get_current_instances_count(self) -> int: Integer that represent the total pending and running instances count for cluster """ pass - - @abc.abstractmethod - def validate_container_definition(self, container_definition: str) -> None: - """Validate the format of a specific container definition. - Raises: - InvalidParameterError: The container definition is not in a valid format. - """ - pass diff --git a/fbpcp/service/onedocker.py b/fbpcp/service/onedocker.py index e809dc8e..ad4efa4b 100644 --- a/fbpcp/service/onedocker.py +++ b/fbpcp/service/onedocker.py @@ -50,8 +50,6 @@ def __init__( if container_svc is None: raise ValueError(f"Dependency is missing. container_svc={container_svc}, ") self.container_svc = container_svc - if task_definition: - self.container_svc.validate_container_definition(task_definition) self.task_definition = task_definition self.metrics: Final[Optional[MetricsEmitter]] = metrics self.logger: logging.Logger = logging.getLogger(__name__) @@ -140,8 +138,6 @@ def start_containers( Returns: A list of the containers that were successfuly started """ - if task_definition: - self.container_svc.validate_container_definition(task_definition) if not cmd_args_list: raise ValueError("Command Argument List shouldn't be None or Empty")