Build failed on Ubuntu 20.04 and 24.04

[iz4tow]

Good morning,
I'm trying to build wdt on Ubuntu 20.04 and 24.04
I tried:

sudo apt update && sudo apt upgrade -y
sudo apt install make cmake g++ gcc -y
sudo apt install libboost-filesystem-dev  libgtest-dev -y
sudo apt install libfmt-dev libfast-float-dev -y
sudo apt-get install libgoogle-glog-dev libboost-system-dev libdouble-conversion-dev libjemalloc-dev -y
git clone https://github.com/facebook/folly
cd folly
sudo ./build/fbcode_builder/getdeps.py install-system-deps --recursive
sudo apt install libssl-dev m4 -y
python3 ./build/fbcode_builder/getdeps.py --allow-system-packages build

All good till here

The problems begins with wdt:

git clone https://github.com/facebook/wdt.git
cd wdt
mkdir _build
cd build
cmake ..
# still no error
make -j #it fails

cmake result:

CMake Deprecation Warning at CMakeLists.txt:19 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


-- The C compiler identification is GNU 13.3.0
-- The CXX compiler identification is GNU 13.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") found components: system filesystem 
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Looking for GFLAGS_NAMESPACE
-- Looking for GFLAGS_NAMESPACE - found
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "3.0.13")  
-- Looking for posix_fallocate
-- Looking for posix_fallocate - found
-- Looking for sync_file_range
-- Looking for sync_file_range - found
-- Looking for posix_memalign
-- Looking for posix_memalign - found
-- Looking for posix_fadvise
-- Looking for posix_fadvise - found
-- Looking for clock_gettime
-- Looking for clock_gettime - found
-- Looking for pthread_atfork
-- Looking for pthread_atfork - found
-- Looking for C++ include linux/sockios.h
-- Looking for C++ include linux/sockios.h - found
-- Performing Test FOLLY_HAVE_WEAK_SYMBOLS
-- Performing Test FOLLY_HAVE_WEAK_SYMBOLS - Success
-- Configuring done (1.4s)
-- Generating done (0.0s)
-- Build files have been written to: /home/test/wdt/_build

make output:

[  2%] Building CXX object CMakeFiles/folly4wdt.dir/home/test/folly/folly/Demangle.cpp.o
[ 17%] Building CXX object CMakeFiles/folly4wdt.dir/home/test/folly/folly/hash/detail/ChecksumDetail.cpp.o
[  4%] Building CXX object CMakeFiles/folly4wdt.dir/home/test/folly/folly/Conv.cpp.o
[ 21%] Building CXX object CMakeFiles/folly4wdt.dir/home/test/folly/folly/detail/SplitStringSimd.cpp.o
[  6%] Building CXX object CMakeFiles/folly4wdt.dir/home/test/folly/folly/lang/CString.cpp.o
[  8%] Building CXX object CMakeFiles/folly4wdt.dir/home/test/folly/folly/lang/ToAscii.cpp.o
[ 10%] Building CXX object CMakeFiles/folly4wdt.dir/home/test/folly/folly/hash/Checksum.cpp.o
[ 13%] Building CXX object CMakeFiles/folly4wdt.dir/home/test/folly/folly/hash/detail/Crc32cDetail.cpp.o
[ 15%] Building CXX object CMakeFiles/folly4wdt.dir/home/test/folly/folly/ScopeGuard.cpp.o
[ 19%] Building CXX object CMakeFiles/folly4wdt.dir/home/test/folly/folly/hash/detail/Crc32CombineDetail.cpp.o
/home/test/folly/folly/Conv.cpp: In function ‘folly::Expected<Tgt, folly::ConversionCode> folly::detail::str_to_floating_fast_float_from_chars(folly::StringPiece*)’:
/home/test/folly/folly/Conv.cpp:365:33: error: ‘allow_leading_plus’ is not a member of ‘fast_float::chars_format’
  365 |       fast_float::chars_format::allow_leading_plus};
      |                                 ^~~~~~~~~~~~~~~~~~
/home/test/folly/folly/Conv.cpp: In instantiation of ‘folly::Expected<Tgt, folly::ConversionCode> folly::detail::str_to_floating_fast_float_from_chars(folly::StringPiece*) [with T = float; folly::StringPiece = folly::Range<const char*>]’:
/home/test/folly/folly/Conv.cpp:379:64:   required from here
/home/test/folly/folly/Conv.cpp:363:29: error: no matching function for call to ‘fast_float::parse_options::parse_options(<brace-enclosed initializer list>)’
  363 |   fast_float::parse_options options{
      |                             ^~~~~~~
In file included from /home/test/folly/folly/Conv.cpp:24:
/usr/include/fast_float/fast_float.h:21:22: note: candidate: ‘constexpr fast_float::parse_options::parse_options(fast_float::chars_format, char)’
   21 |   constexpr explicit parse_options(chars_format fmt = chars_format::general,
      |                      ^~~~~~~~~~~~~
/usr/include/fast_float/fast_float.h:21:22: note:   conversion of argument 1 would be ill-formed:
/usr/include/fast_float/fast_float.h:20:8: note: candidate: ‘constexpr fast_float::parse_options::parse_options(const fast_float::parse_options&)’
   20 | struct parse_options {
      |        ^~~~~~~~~~~~~
/usr/include/fast_float/fast_float.h:20:8: note:   conversion of argument 1 would be ill-formed:
/usr/include/fast_float/fast_float.h:20:8: note: candidate: ‘constexpr fast_float::parse_options::parse_options(fast_float::parse_options&&)’
/usr/include/fast_float/fast_float.h:20:8: note:   conversion of argument 1 would be ill-formed:
/home/test/folly/folly/Conv.cpp: In instantiation of ‘folly::Expected<Tgt, folly::ConversionCode> folly::detail::str_to_floating_fast_float_from_chars(folly::StringPiece*) [with T = double; folly::StringPiece = folly::Range<const char*>]’:
/home/test/folly/folly/Conv.cpp:381:65:   required from here
/home/test/folly/folly/Conv.cpp:363:29: error: no matching function for call to ‘fast_float::parse_options::parse_options(<brace-enclosed initializer list>)’
  363 |   fast_float::parse_options options{
      |                             ^~~~~~~
/usr/include/fast_float/fast_float.h:21:22: note: candidate: ‘constexpr fast_float::parse_options::parse_options(fast_float::chars_format, char)’
   21 |   constexpr explicit parse_options(chars_format fmt = chars_format::general,
      |                      ^~~~~~~~~~~~~
/usr/include/fast_float/fast_float.h:21:22: note:   conversion of argument 1 would be ill-formed:
/usr/include/fast_float/fast_float.h:20:8: note: candidate: ‘constexpr fast_float::parse_options::parse_options(const fast_float::parse_options&)’
   20 | struct parse_options {
      |        ^~~~~~~~~~~~~
/usr/include/fast_float/fast_float.h:20:8: note:   conversion of argument 1 would be ill-formed:
/usr/include/fast_float/fast_float.h:20:8: note: candidate: ‘constexpr fast_float::parse_options::parse_options(fast_float::parse_options&&)’
/usr/include/fast_float/fast_float.h:20:8: note:   conversion of argument 1 would be ill-formed:
make[2]: *** [CMakeFiles/folly4wdt.dir/build.make:76: CMakeFiles/folly4wdt.dir/home/test/folly/folly/Conv.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:142: CMakeFiles/folly4wdt.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

cmake version: 3.28.3
GNU Make version: 4.3
g++/gcc version: (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0
Python version: 3.12.3

[ijsf]

I ran into the same issue, but found out that the version of libfast-float-dev shipped on Debian and Ubuntu in stable and possibly other versions is seriously outdated. At least 2 years. It's likely you have 3.9.0-1 instead of 8.0.0-0.1 and folly and wdt require a newer version.

There's a few ways to fix this. Either add the testing apt source to your system, or go to the fastfloat/fast_float repo and just clone and cmake --install it.