format code/code refactor

[ayrat555]

format code with elixir code formatter and refactor if necessary

For example,

    # The following checks Holistic Validity, as defined in Eq.(29)
    errors = []
      ++ if child_block.header.state_root == block.header.state_root, do: [], else: [:state_root_mismatch]
      ++ if child_block.header.ommers_hash == block.header.ommers_hash, do: [], else: [:ommers_hash_mismatch]
      ++ if child_block.header.transactions_root == block.header.transactions_root, do: [], else: [:transactions_root_mismatch]
      ++ if child_block.header.receipts_root == block.header.receipts_root, do: [], else: [:receipts_root_mismatch]

turns into

    # The following checks Holistic Validity, as defined in Eq.(29)
    errors =
      [] ++
        if child_block.header.state_root == block.header.state_root,
          do: [],
          else:
            [:state_root_mismatch] ++
              if(
                child_block.header.ommers_hash == block.header.ommers_hash,
                do: [],
                else:
                  [:ommers_hash_mismatch] ++
                    if(
                      child_block.header.transactions_root == block.header.transactions_root,
                      do: [],
                      else:
                        [:transactions_root_mismatch] ++
                          if(
                            child_block.header.receipts_root == block.header.receipts_root,
                            do: [],
                            else: [:receipts_root_mismatch]
                          )
                    )
              )

[hayesgm]

Yup, there should be a number of ways to refactor that code that would end up a lot cleaner. Possibly a number of function called piped to each other, for instance. Or even, just binding each of the ++ clauses to variables and ending with the concatentation of them.

[atoulme]

I don't see this particular code path and its formatting.

I am reenabling formatting checks as part of the build and adding a formatting configuration file, as well as its effects in #22. Please let me know if this helps.