Conversation
Categories: - app-store: App Store Connect, ASO, screenshots, simulator - advertising: Apple Search Ads, Google Ads, Meta Ads, DataForSEO, SEO - analytics: Appfigures, last30days, content performance - marketing: brand, copywriting, content strategy, growth, pricing, churn - writing: articles, editor, outlines, Substack, evaluate-content - creative: video, screen recording, Kling, Seedance, Remotion, nano-banana-pro - visual-design: design review, UI wiki, Excalidraw, impeccable, + existing sub-skills - finance: Alpaca, Copilot Money, stock research, earnings, market briefing - social-media: tweets, Typefully, Whop, Bloom features, NotebookLM - devops: cloud migration, deploy, Railway, Render, documents, security - coding: superpowers, React Doctor, context7, Codex, simplify, serena, ralph, babysit-pr - ai-tools: agent browser, grok search, web search - bloom: CLI, PR fixes, demo features - openclaw: memory setup, resiliency, hooks, Sentry - skills-meta: audit, creator, improver, dogfood - research: synthetic user studies, YC office hours, trip planner, another-perspective
|
Claude finished @exiao's task in 4m 53s —— View job PR Review: Reorganize skills into category folders
Scope mismatchThe PR description says "Moves 110+ flat skills into organized category folders. No functionality changes." but the diff tells a different story:
Missing from the PR description: This should be documented accurately so reviewers know what they're approving. Issues found1. Broken cross-references (2 missing skills)
2. README.md files inside skill directoriesPer repo conventions (
3. DESCRIPTION.md format inconsistenciesTwo DESCRIPTION.md files don't follow the YAML-frontmatter-only pattern used by the other 36:
4.
|
There was a problem hiding this comment.
Review: Request Changes
Scope mismatch: PR description lists 15 categories and "no functionality changes," but the diff adds ~91 new SKILL.md files, ~40 categories (vs. 15 documented), and a .bundled_manifest. The description should accurately reflect what's being merged.
Issues to fix:
- Broken cross-references:
content-managementskill referenced bysocial-media/typefully/SKILL.mdandvisual-design/slideshow-creator/SKILL.mddoesn't exist.healthcheckskill referenced bydevops/security-audit/SKILL.mddoesn't exist. - README.md in skill dirs:
creative/ascii-video/,creative/manim-video/,creative/p5js/,mlops/training/grpo-rl-training/, andresearch/research-paper-writing/templates/contain README.md files, violating repo conventions. - Inconsistent DESCRIPTION.md:
inference-sh/DESCRIPTION.mdlacks YAML frontmatter;domain/DESCRIPTION.mdhas extra fields and a markdown body unlike all other DESCRIPTION.md files.
No hardcoded secrets found. The email-sequence → churn-prevention cross-reference fix is correct.
See full review in PR comment.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f60eb68474
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -109,7 +109,7 @@ Reference for all lifecycle message types. Covers push notifications (available | |||
| **Trigger:** RevenueCat `BILLING_ISSUE` event | |||
| **Goal:** Recover revenue, retain subscriber | |||
|
|
|||
| See [churn-prevention skill](../../churn-prevention/SKILL.md) for the full billing issue sequence. | |||
| See [churn-prevention skill](../churn-prevention/SKILL.md) for the full billing issue sequence. | |||
There was a problem hiding this comment.
Fix churn-prevention reference path
The updated link now points to ../churn-prevention/SKILL.md, but from marketing/email-sequence/references/ that resolves to marketing/email-sequence/churn-prevention/SKILL.md, which does not exist. This breaks the documented handoff for failed-payment recovery workflows; the sibling skill under marketing/ requires going up two levels (../../churn-prevention/SKILL.md).
Useful? React with 👍 / 👎.
Skills Repo Reorganization
Moves 110+ flat skills into organized category folders. No functionality changes — Hermes uses
rglob("SKILL.md")so nesting doesn't affect discovery.Categories (15)
Cross-reference fix
Plan
https://skills-reorg.surge.sh