Review convert if/ternary expression analyzer comment in leap year

[kahgoh]

The analyzer produces the comment Consider converting the if-statement(s) and/or ternary expressions into a single expression using the && and || operators. for the solution return (year % 100 == 0) ? (year % 400 == 0) : (year % 4 == 0);.

The solution seems valid (so the analyzer shouldn't produce the comment).

[jagdish-15]

Hey @kahgoh, could you assign the issue to me?

[jagdish-15]

Hello @kahgoh,

I've raised two PRs related to this issue — one on java-analyzer and another on website-copy.

I'm still unsure about the analyzer tests for the java-analyzer PR. Could you please clarify what's expected in terms of testing? Also, let me know if there's anything else that needs to be updated or adjusted in either of the PRs.

[kahgoh]

I think we need to update the tests - there's a few failing in the CI. If I'm not mistaken, the sample for the ternary test, we would expect to receive to get the new ternary comment because the last case returns a boolean literal. But, we also need to add one a test for the return (year % 100 == 0) ? (year % 400 == 0) : (year % 4 == 0); solution, which I think should receive no analyzer comments.

[jagdish-15]

Let's close this issue now!

[kahgoh]

Oh yes, PR #260 has been merged. Closing this issue.