From 19d5450542c77cc3ae3c445e0b705549eb452800 Mon Sep 17 00:00:00 2001 From: Tim Rasim <2033832+neogucky@users.noreply.github.com> Date: Wed, 28 Jan 2026 15:07:20 +0100 Subject: [PATCH 1/3] SED-4496 Correctly disable plan editor environment when unset --- .../plan-editor-actions.component.html | 3 +-- .../plan-editor-actions/plan-editor-actions.component.ts | 8 ++++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html b/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html index a95797c96..4d6c908c3 100644 --- a/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html +++ b/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html @@ -95,13 +95,12 @@ @if (_interactiveSession.hasExecutionParameters()) { - + diff --git a/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.ts b/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.ts index 418b5a67c..cbd65e1b6 100644 --- a/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.ts +++ b/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.ts @@ -110,8 +110,12 @@ export class PlanEditorActionsComponent { } setTargetExecutionParameters(parameters?: Record) { - this.targetExecutionParameters = parameters; - this.targetExecutionParametersChange.emit(parameters as Record); + const nonEmptyParameters = Object.fromEntries( + Object.entries(parameters ?? {}).filter(([, value]) => value !== undefined), + ) as Record; + + this.targetExecutionParameters = nonEmptyParameters; + this.targetExecutionParametersChange.emit(nonEmptyParameters as Record); } protected readonly Object = Object; From 0779439ffc9b95fa0c217eede581f4abc9d5597d Mon Sep 17 00:00:00 2001 From: Tim Rasim <2033832+neogucky@users.noreply.github.com> Date: Wed, 28 Jan 2026 22:25:05 +0100 Subject: [PATCH 2/3] SED-4496 improved target execution parameters button --- .../components/popover/popover.component.scss | 4 +- .../components/popover/popover.component.ts | 69 +++++++++++-------- .../plan-editor-actions.component.html | 35 +++++----- 3 files changed, 61 insertions(+), 47 deletions(-) diff --git a/projects/step-core/src/lib/modules/basics/components/popover/popover.component.scss b/projects/step-core/src/lib/modules/basics/components/popover/popover.component.scss index 6097a6ed9..ee1de9427 100644 --- a/projects/step-core/src/lib/modules/basics/components/popover/popover.component.scss +++ b/projects/step-core/src/lib/modules/basics/components/popover/popover.component.scss @@ -94,7 +94,7 @@ } } &.bottom-left { - margin-bottom: 0.5rem; + margin-bottom: 1rem; margin-right: -2.5rem; .step-popover__arrow { @@ -107,7 +107,7 @@ } } &.bottom-right { - margin-bottom: 0.5rem; + margin-bottom: 1rem; margin-left: -2.5rem; .step-popover__arrow { diff --git a/projects/step-core/src/lib/modules/basics/components/popover/popover.component.ts b/projects/step-core/src/lib/modules/basics/components/popover/popover.component.ts index 54330893e..b6dd6dc47 100644 --- a/projects/step-core/src/lib/modules/basics/components/popover/popover.component.ts +++ b/projects/step-core/src/lib/modules/basics/components/popover/popover.component.ts @@ -56,7 +56,7 @@ export class PopoverComponent implements PopoverService, AfterViewInit, OnDestro @ViewChild('popoverTemplate', { static: true }) popoverTemplate!: TemplateRef; readonly xPosition = input<'before' | 'after'>('after'); - readonly yPosition = input<'above' | 'below'>('above'); + readonly yPosition = input<'above' | 'below'>('below'); readonly noPadding = input(false); readonly withBorder = input(false); readonly whiteBackground = input(false); @@ -114,35 +114,12 @@ export class PopoverComponent implements PopoverService, AfterViewInit, OnDestro private createOverlay(): void { if (this.overlayRef) return; + const positions = this.buildPositions(); + this.positionStrategy = this.overlay .position() .flexibleConnectedTo(this._el) - .withPositions([ - { - originX: 'center', - originY: 'bottom', - overlayX: 'start', - overlayY: 'top', - }, - { - originX: 'center', - originY: 'bottom', - overlayX: 'end', - overlayY: 'top', - }, - { - originX: 'center', - originY: 'top', - overlayX: 'end', - overlayY: 'bottom', - }, - { - originX: 'center', - originY: 'top', - overlayX: 'end', - overlayY: 'bottom', - }, - ]) + .withPositions(positions) .withViewportMargin(8) .withPush(false); @@ -167,6 +144,44 @@ export class PopoverComponent implements PopoverService, AfterViewInit, OnDestro }); } + private buildPositions(): ConnectedPosition[] { + const isBelow = this.yPosition() === 'below'; + const preferLeft = this.xPosition() === 'before'; + + const buildPosition = ( + originY: 'top' | 'bottom', + overlayY: 'top' | 'bottom', + overlayX: 'start' | 'end', + ): ConnectedPosition => ({ + originX: 'center', + originY, + overlayX, + overlayY, + }); + + const primary = buildPosition(isBelow ? 'bottom' : 'top', isBelow ? 'top' : 'bottom', preferLeft ? 'end' : 'start'); + + const secondary = buildPosition( + isBelow ? 'bottom' : 'top', + isBelow ? 'top' : 'bottom', + preferLeft ? 'start' : 'end', + ); + + const fallbackPrimary = buildPosition( + isBelow ? 'top' : 'bottom', + isBelow ? 'bottom' : 'top', + preferLeft ? 'end' : 'start', + ); + + const fallbackSecondary = buildPosition( + isBelow ? 'top' : 'bottom', + isBelow ? 'bottom' : 'top', + preferLeft ? 'start' : 'end', + ); + + return [primary, secondary, fallbackPrimary, fallbackSecondary]; + } + private setBackdropActive(active: boolean): void { const backdrop = this.overlayRef?.backdropElement; if (!backdrop) return; diff --git a/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html b/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html index 4d6c908c3..661adc0d2 100644 --- a/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html +++ b/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html @@ -95,24 +95,15 @@ @if (_interactiveSession.hasExecutionParameters()) { - - - - Advanced: Set target execution parameters so the editor can display the right Keyword or Plan version (See - Automation Packages: Versions). - - +
+ Target Execution Parameters (advaned)
Display the right Keyword or Plan version in the editor
(See + Automation Packages: Versions).
@if (_interactiveSession.hasExecutionParameters()) { Date: Thu, 5 Feb 2026 16:58:21 +0100 Subject: [PATCH 3/3] Update projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- .../plan-editor-actions/plan-editor-actions.component.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html b/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html index 661adc0d2..c753259d2 100644 --- a/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html +++ b/projects/step-frontend/src/lib/modules/plan-editor/components/plan-editor-actions/plan-editor-actions.component.html @@ -160,7 +160,7 @@
Target Execution Parameters (advaned)
Display the right Keyword or Plan version in the editor
(See + >Target Execution Parameters (advanced)
Display the right Keyword or Plan version in the editor
(See