fix(parser): handle quotes inside ${...} in double-quoted strings

The lexer now tracks ${...} brace depth inside double-quoted strings
so that inner quotes (e.g. ${arr["key"]}) don't terminate the outer
string. Also strips surrounding quotes from array indices during parsing.

Closes #399

https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy

Author: claude

crates/bashkit/src/interpreter/mod.rs

@@ -9686,4 +9686,30 @@ bash /tmp/opts.sh -f xml -v
         assert_eq!(lines[0], "FORMAT=json VERBOSE=1");
         assert_eq!(lines[1], "FORMAT=xml VERBOSE=1");
     }
+
+    #[tokio::test]
+    async fn test_assoc_array_in_double_quotes() {
+        // Issue #399: ${arr["key"]} inside double quotes misparsed
+        let mut bash = crate::Bash::new();
+        let result = bash
+            .exec(r#"declare -A arr; arr["foo"]="bar"; echo "value: ${arr["foo"]}""#)
+            .await
+            .unwrap();
+        assert_eq!(result.stdout.trim(), "value: bar");
+    }
+
+    #[tokio::test]
+    async fn test_assoc_array_keys_in_quotes() {
+        // Issue #399: ${!arr[@]} in string context
+        let mut bash = crate::Bash::new();
+        let result = bash
+            .exec(r#"declare -A arr; arr["a"]=1; arr["b"]=2; echo "keys: ${!arr[@]}""#)
+            .await
+            .unwrap();
+        let output = result.stdout.trim();
+        // Keys may be in any order
+        assert!(output.starts_with("keys: "), "got: {}", output);
+        assert!(output.contains("a"), "got: {}", output);
+        assert!(output.contains("b"), "got: {}", output);
+    }
 }

crates/bashkit/src/parser/lexer.rs

@@ -1043,6 +1043,12 @@ impl<'a> Lexer<'a> {
                         content.push('(');
                         self.advance();
                         self.read_command_subst_into(&mut content);
+                    } else if self.peek_char() == Some('{') {
+                        // ${...} parameter expansion — track brace depth so
+                        // inner quotes (e.g. ${arr["key"]}) don't end the string
+                        content.push('{');
+                        self.advance();
+                        self.read_param_expansion_into(&mut content);
                     }
                 }
                 '`' => {
@@ -1170,6 +1176,82 @@ impl<'a> Lexer<'a> {
         }
     }
 
+    /// Read parameter expansion content after `${`, handling nested braces and quotes.
+    /// In bash, quotes inside `${...}` (e.g. `${arr["key"]}`) don't terminate the
+    /// outer double-quoted string. Appends chars including closing `}` to `content`.
+    fn read_param_expansion_into(&mut self, content: &mut String) {
+        let mut depth = 1;
+        while let Some(c) = self.peek_char() {
+            match c {
+                '{' => {
+                    depth += 1;
+                    content.push(c);
+                    self.advance();
+                }
+                '}' => {
+                    depth -= 1;
+                    self.advance();
+                    content.push('}');
+                    if depth == 0 {
+                        break;
+                    }
+                }
+                '"' => {
+                    // Quotes inside ${...} are part of the expansion, not string delimiters
+                    content.push('"');
+                    self.advance();
+                }
+                '\'' => {
+                    content.push('\'');
+                    self.advance();
+                }
+                '\\' => {
+                    // Inside ${...} within double quotes, same escape rules apply:
+                    // \", \\, \$, \` produce the escaped char; others keep backslash
+                    self.advance();
+                    if let Some(esc) = self.peek_char() {
+                        match esc {
+                            '"' | '\\' | '$' | '`' => {
+                                content.push(esc);
+                                self.advance();
+                            }
+                            '}' => {
+                                // \} should be a literal } without closing the expansion
+                                content.push('\\');
+                                content.push('}');
+                                self.advance();
+                            }
+                            _ => {
+                                content.push('\\');
+                                content.push(esc);
+                                self.advance();
+                            }
+                        }
+                    } else {
+                        content.push('\\');
+                    }
+                }
+                '$' => {
+                    content.push('$');
+                    self.advance();
+                    if self.peek_char() == Some('(') {
+                        content.push('(');
+                        self.advance();
+                        self.read_command_subst_into(content);
+                    } else if self.peek_char() == Some('{') {
+                        content.push('{');
+                        self.advance();
+                        self.read_param_expansion_into(content);
+                    }
+                }
+                _ => {
+                    content.push(c);
+                    self.advance();
+                }
+            }
+        }
+    }
+
     /// Check if the content starting with { looks like a brace expansion
     /// Brace expansion: {a,b,c} or {1..5} (contains , or ..)
     /// Brace group: { cmd; } (contains spaces, semicolons, newlines)

crates/bashkit/src/parser/mod.rs

@@ -2379,6 +2379,12 @@ impl<'a> Parser<'a> {
                                 }
                                 index.push(chars.next().unwrap());
                             }
+                            // Strip surrounding quotes from index (e.g. "foo" -> foo)
+                            if (index.starts_with('"') && index.ends_with('"'))
+                                || (index.starts_with('\'') && index.ends_with('\''))
+                            {
+                                index = index[1..index.len() - 1].to_string();
+                            }
                             // After ], check for operators on array subscripts
                             if let Some(&next_c) = chars.peek() {
                                 if next_c == ':' && (index == "@" || index == "*") {