Skip to content

fortune -> 생년월일 유효성 체크 로직 추가, 테스트 코드 추가 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
easternkite merged 1 commit into from
Feb 20, 2025
Merged

fortune -> 생년월일 유효성 체크 로직 추가, 테스트 코드 추가 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions src/main/kotlin/com/easternkite/remain/features/fortune/FortuneRoute.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,26 +61,25 @@ fun Application.fortuneRoute() {
}
)
)
val birth = body
.text
.takeIf { it.length == 6 }
?.takeIf { it.matches("[0-9]+".toRegex()) }
?: run {
val errorResponse = DrResponse(
text = "${HttpStatusCode.BadRequest} - 생년월일은 숫자로 이루어진 6자리여야 합니다.",
responseType = "ephemeral" // 작성자한테만 표시
)
val birth = body.text
if (!validateBirth(birth)) {
val errorResponse = DrResponse(
text = "${HttpStatusCode.BadRequest} - 생년월일은 숫자로 이루어진 6자리여야 합니다.",
responseType = "ephemeral" // 작성자한테만 표시
)

call.respondText(
text = Json.encodeToString(errorResponse),
contentType = ContentType.Application.Json
)
return@post
}

call.respondText(
text = Json.encodeToString(errorResponse),
contentType = ContentType.Application.Json
)
return@post
}
val userTag = DoorayTag.create(
tenantId = body.tenantId,
userId = body.userId
)

val response = chat.sendMessage("생년월일 : ${birth}, 기준 날짜 : $currentTimeFormatted")
val fortuneJson = response.text?.let { text ->
println(text)
Expand Down Expand Up @@ -126,6 +125,20 @@ fun Application.fortuneRoute() {
}
}

fun validateBirth(birth: String): Boolean {
if (birth.length != 6) return false

val (_, month, day) = runCatching {
birth.chunked(2) { it.toString().toInt() }
}.getOrNull() ?: return false

val isPossibleMonth = month in 1..12
val isPossibleDay = day in 1 .. 31

return isPossibleMonth && isPossibleDay
}


data class FortuneField(
val title: String,
val section: Section,
Expand Down
48 changes: 48 additions & 0 deletions src/test/kotlin/com/easternkite/remain/features/fortune/FortuneRouteKtTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package com.easternkite.remain.features.fortune

import org.junit.Test
import kotlin.test.assertFalse
import kotlin.test.assertTrue

class ValidateBirthTest {

@Test
fun `생년월일이 6자 이상일 때 false`() {
assertFalse(validateBirth("9709088"))
}

@Test
fun `생년월일중, 태어난 달이 12월을 초과할 때 false`() {
assertFalse(validateBirth("971308"))
}

@Test
fun `생년월일중, 태어난 일이 31일을 초과할 때 false`() {
assertFalse(validateBirth("970132"))
}

@Test
fun `태어난 월, 일이 0일 때 false`() {
assertFalse(validateBirth("000000"))
}

@Test
fun `태어난 월, 일이 99일 때 false`() {
assertFalse(validateBirth("999999"))
}

@Test
fun `99년 12월 31일 경계값 true`() {
assertTrue(validateBirth("991231"))
}

@Test
fun `00년 01월 01일 경계값 true`() {
assertTrue(validateBirth("000101"))
}

@Test
fun `한글, 특수문자 들어가 있는 경우 false`() {
assertFalse(validateBirth("__--얍얍"))
}
}