Duplicate conditional checks

[cgewecke]

Tests / coverage suggest that the libraries & DB contracts duplicate several conditional checks. Some library conditionals always evaluate to true. These might be candidates for excision, or the contracts could be refactored to consume the library validations rather than implementing their own. Another option is to leave well enough alone and preserve the code's current level of decoupling.

• SemVersionLib.isGreater() checks to see if two hashes are equal. It looks like the only existing path to it is from ReleaseDB.isLatestMajorTree() through SemVersionLib.isGreaterOrEqual() which also checks equality.

• IndexedOrderedSetLib implements two strategies to verify the existence of an item in the set before performing an operation, both duplicated by upstream checks at ReleaseDB.

  • .add() checks to see if the set already contains the added value here, returning true if it is. This path is only reached through ReleaseDB.setRelease() which runs its own existence checks here
  • .remove() is modified by .requireValue() which throws if the value isn't found. This path is only reached through ReleaseDB.removeRelease() which runs its own existence checks here.