-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
NFT_market_contract.sol
L96 unused,
L124 reduce the cal of Hash
L125 check the returned success1 value to determine if continue or not (and what the 1 stands for ?)
L184 cal Hash after the expiration checked passed
L209 isOrderInvalid
L230: 1. impossible case, 2. both event for success and fail would be triggered
L416: just transfer 721 is not 'atomic', do both side (transfer money to seller)
- since this is a public function, have to check expiration here, otherwise the
expirationwould be useless
L463 check seller with owner, don't want to record other user's info
price of ERC20 and ETD should be distinguished
Metadata
Metadata
Assignees
Labels
No labels