fix: support testing without flasher_args.json (CII-159)#413
Open
Honza0297 wants to merge 1 commit intoespressif:mainfrom
Open
fix: support testing without flasher_args.json (CII-159)#413Honza0297 wants to merge 1 commit intoespressif:mainfrom
Honza0297 wants to merge 1 commit intoespressif:mainfrom
Conversation
github-actions
bot
changed the title
|
hfudev
reviewed
Apr 13, 2026
Member
hfudev
left a comment
hfudev
left a comment
There was a problem hiding this comment.
LGTM. These two places are all using IdfApp, which makes me think calling self.app.is_linux_elf directly is safe. WDYT?
This allows testing IDF_TARGET_LINUX builds (APP_BUILD_TYPE_ELF_ONLY) even without an esptool flasher_args file present, by skipping flash- related operations (serial flash, JTAG flash, flash args parsing) when the build is a Linux host ELF-only output. Made-with: Cursor
Author
|
@hfudev Thanks for the review! You were right, I changed |
Author
|
By the way, any idea why the CI is failing? To be honest, I am not sure I understand why it fails in the first place... Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows testing build where only the ELF file is generated without flashable binaries. This can be the case e.g. for linux builds.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: