Secrets cause problem in output name

[pilotak]

when compiling and using secrets.yaml the steps.esphome.outputs.name will begin with !secrets

Copied factory binary to: !secret ssid-esp32c3/!secret ssid-esp32c3.factory.bin
Copied OTA binary to: !secret ssid-esp32c3/!secret ssid-esp32c3.ota.bin
Copied ELF file to: !secret ssid-esp32c3/!secret ssid-esp32c3.elf

device.yaml

substitutions:
  fw_ver: "v1.0.3"
  
esphome:
  name: test
  friendly_name: test

esp32:
  board: esp32-c3-devkitm-1
  framework:
    type: esp-idf

logger:

ota:
  - platform: esphome

wifi:
  ap:
    ssid: !secret ssid
    password: !secret password

secrets.yaml

ssid: "test"
password: "12345678"

You can see it in action https://github.com/pilotak/test/actions/runs/13375134420/job/37352565907

[jzucker2]

Idk if this can be incorporated with my approach esphome/workflows#119

But I tried a solution for secrets in CI too

[jesserockz]

Sorry for the delay @pilotak

https://github.com/jesserockz/esphome-build-action-secret-test/actions/runs/14765223146/job/41455127509#step:7:1

Forked your repo and it is working correctly for me 🙈

  Copied factory binary to: test-esp32c3/test-esp32c3.factory.bin
  Copied OTA binary to: test-esp32c3/test-esp32c3.ota.bin
  Copied ELF file to: test-esp32c3/test-esp32c3.elf

My secret contains:

ssid: Some_SSID
password: Some_Password

[jesserockz]

Ah, I just realised the issue, The ESPHome config dump will turn any value that matches a secret value back into the !secret key form.

Which in your case is the name as "test" is the same value as the ssid secret.

[pilotak]

Well this is interesting. So the only fix is not to have unique names for now and this will get possibly fixed?

[jesserockz]

Yes, for now you need to either change your ap ssid, or just remove that field, as it automatically takes on the name on the device if not specified. (Assuming your actual usage of this is for the ap name)