Skip to content

Support any Into<String> type for a few APIs #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tekjar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support any Into<String> type for a few APIs #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/kucoin/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ pub struct Credentials {
}

impl Credentials {
pub fn new(api_key: &str, secret_key: &str, passphrase: &str) -> Self {
pub fn new<S: Into<String>>(api_key: S, secret_key: S, passphrase: S) -> Self {
Credentials {
api_key: api_key.to_string(),
secret_key: secret_key.to_string(),
passphrase: passphrase.to_string(),
api_key: api_key.into(),
secret_key: secret_key.into(),
passphrase: passphrase.into(),
}
}
}
Expand Down Expand Up @@ -70,12 +70,12 @@ impl Kucoin {

// Generic get request for internal library use.
// Matches credentials for signed vs. unsigned API calls
pub async fn get(
pub async fn get<S: Into<String>>(
&self,
url: String,
url: S,
sign: Option<HeaderMap>,
) -> Result<reqwest::Response, APIError> {
let req_url = reqwest::Url::parse(&url).unwrap();
let req_url = reqwest::Url::parse(&url.into()).unwrap();
match sign {
Some(sign) => {
let resp = self.client.get(req_url).headers(sign).send().await?;
Expand Down Expand Up @@ -203,12 +203,14 @@ impl Kucoin {
}
}
}
let mut hmac_sign = HmacSha256::new_varkey(secret_key.as_bytes()).expect("HMAC can take key of any size");
let mut hmac_sign =
HmacSha256::new_varkey(secret_key.as_bytes()).expect("HMAC can take key of any size");
hmac_sign.input(str_to_sign.as_bytes());
let sign_result = hmac_sign.result();
let sign_bytes = sign_result.code();
let sign_digest = encode(&sign_bytes);
let mut hmac_passphrase = HmacSha256::new_varkey(secret_key.as_bytes()).expect("HMAC can take key of any size");
let mut hmac_passphrase =
HmacSha256::new_varkey(secret_key.as_bytes()).expect("HMAC can take key of any size");
hmac_passphrase.input(passphrase.as_bytes());
let passphrase_result = hmac_passphrase.result();
let passphrase_bytes = passphrase_result.code();
Expand Down