building linpack on Windows

[mikemadden42]

Has linpack been built & tested on Windows. When I use cmake & ninja to build on Windows, I'm getting this warning about getenv.

-- The C compiler identification is MSVC 19.24.28315.0
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/BuildTools/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Users/michael_madden/src/linpack/build
[1/2] Building C object CMakeFiles\linpack.dir\linpack.c.obj
..\linpack.c(74): warning C4996: 'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
C:\Program Files (x86)\Windows Kits\10\include\10.0.18362.0\ucrt\stdlib.h(1191): note: see declaration of 'getenv'
[2/2] Linking C executable linpack.exe

[mikemadden42]

I found an additional warning when building linpack on Windows:

..\linpack.c(91): warning C4477: 'printf' : format string '%ld' requires an argument of type 'long', but variadic argument 1 has type 'size_t'
..\linpack.c(91): note: consider using '%zd' in the format string

[ereyes01]

Hi thanks for reporting! I've never personally tested this on Windows unfortunately, only the Docker/linux environment.

The format string warning looks reasonable, as %zu seems the more cross-platform way to print a size_t. The getenv warning probably requires some #ifdef soup to be safe/valid on all platforms. Based on what I've read, _dupeenv_s is a Microsoft-only thing.

I'm not sure if there's other issues on Windows. I don't have a Windows build machine I can easily test this on...