From 412ecd0f4905ea0f5c2a2701eed59bdb0ab0865f Mon Sep 17 00:00:00 2001 From: abdulrehman ajmal Date: Fri, 9 Aug 2024 22:53:04 +0500 Subject: [PATCH 1/6] contribution md added --- CONTRIBUTION.md | 57 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 CONTRIBUTION.md diff --git a/CONTRIBUTION.md b/CONTRIBUTION.md new file mode 100644 index 0000000..44c126d --- /dev/null +++ b/CONTRIBUTION.md @@ -0,0 +1,57 @@ +# Contributing Guidelines + +Thank you for your interest in contributing to our project. Please follow these guidelines to ensure consistency and maintainability of our codebase. + +## JavaScript Guidelines + +1. Use ES5 JavaScript, with limited exceptions: + - `await` and `?.` are allowed + - Arrow functions `() => foo` are acceptable for single-line expressions + - Avoid ES6+ features like template literals, `const`, and destructuring + +2. Variable Naming: + - Use single, short word variable names + - Avoid `snake_case`, `foo_bar`, or `foo__bar` naming conventions + - For related variables, use nested objects or function properties: + ```javascript + var timer = {}; + timer.at = x; + timer.end = 1000; + timer.on = function() { /* ... */ }; + ``` + +3. DOM Manipulation: + - Prefer jQuery for consistency + - Avoid mixing jQuery with native DOM methods unless absolutely necessary + +4. Code Structure: + - Keep logically atomic operations on a single line, even if it wraps + - Maintain "flat" function structures with early returns for conditions + - Group declarations at the beginning of functions + +5. HTML and Attributes: + - Keep HTML attributes on a single line, except for logic handlers + - Place SVG path data at the bottom of the file and reference it in the markup + +## CSS Guidelines + +1. Avoid rigid sizing: + - Use `min-width` instead of `width` when setting constraints + - Be cautious with `overflow: hidden` on the `body` + +2. Responsive Design: + - Ensure layouts work well across different browser window sizes + - Use flexible units and responsive techniques + +## General Guidelines + +1. Maintain consistent indentation and formatting +2. Write clear, concise comments for complex logic +3. Optimize for readability and maintainability +4. Test thoroughly across different devices and browsers + +## Third-Party Libraries + +- We're open to trying AlpineJS, but implementation should be carefully considered + +Remember, these guidelines are meant to improve code quality and consistency. If you have any questions or suggestions, please don't hesitate to reach out to the project maintainers. \ No newline at end of file From fd7ab54b928baa03625cf7c709a4b5abb760bf31 Mon Sep 17 00:00:00 2001 From: abdulrehman ajmal Date: Mon, 12 Aug 2024 14:56:32 +0500 Subject: [PATCH 2/6] fixed js, css and layout --- +/help/deposit.html | 882 +++++++++++++++++--------------------------- 1 file changed, 330 insertions(+), 552 deletions(-) diff --git a/+/help/deposit.html b/+/help/deposit.html index 9f443c0..1de807c 100644 --- a/+/help/deposit.html +++ b/+/help/deposit.html @@ -1,13 +1,15 @@
-
-
-
+
+
-

Review Check for Deposit

-
+

Review Check for Deposit

+

There is a problem with your check. First, ask the payer to open the same link while you are both online at the same time, then hit refresh. If the check displays for them but not you, have them re-send you the link so the decryption password matches. If things still do not work, please have them write a new check and contact us with a report at checkard@era.eco.

-

+

Warning: For optimal results, switch to a larger display to follow these instructions properly.

@@ -267,131 +199,44 @@

Review Check for Deposit

going paperless!

-
step 1 of 7
+
Step 1 of 7
-
+
-

Endorse the Check

-
+

Endorse the Check

+

Type your name onto the back of the check. If your bank requires a "for deposit only" notice, add it onto the 2nd line. For more help, read the CFPB's guide.

-
step 2 of 7
+
Step 2 of 7
-
+
- - - - - - - - - - - - - - - + -

Prepare for Check Deposit

-
-

+

Prepare for Check Deposit

+
+

Warning: Your bank will reject the deposit if any artifact, reflection, mouse, toolbar, or dust interferes with the photos.

@@ -403,7 +248,7 @@

Prepare for Check Deposit

  • Low-Glare Environment: - Go into a dark room with low screen brightness to avoid reflections. + Go into a dark room with low screen brightness to avoid reflections.
  • Avoid MoirĂ© Pattern: @@ -411,11 +256,11 @@

    Prepare for Check Deposit

    • -
    step 3 of 7
    +
    Step 3 of 7
    -
    +
    Prepare for Check Deposit > -

    Open Bank App on Your Phone

    -
    +

    Open Bank App on Your Phone

    +

    Checkard is only compatible with US based banks that support mobile check depositing. If your bank does not have this feature, you can print the check and take it into a branch.

    Open your bank's app on your phone and find a "Check Deposit" option in the main menu or banking services section after logging in. Never share your banking information with us or others.

    -
    step 4 of 7
    +
    Step 4 of 7
    -
    +
    Open Bank App on Your Phone > -

    Capture Front Image of the Check

    -
    +

    Capture Front Image of the Check

    +

    - Follow your bank app's instructions and take a photo of the check. Remember: Any artifact, including your screen's frame or case, dust, mouse, these instructions, glare or toolbars MUST be hidden. + Follow your bank app's instructions and take a photo of the check. Remember: Any artifact, including your screen's frame or case, dust, mouse, these instructions, glare or toolbars MUST be hidden.

    Zoom in or out with CMD/CTRL +/-. Tap next step to flip the check.

    -
    step 5 of 7
    +
    Step 5 of 7
    -
    +
    Capture Front Image of the Check > -

    Capture Back Image of the Check

    -
    +

    Capture Back Image of the Check

    +

    Almost done! Now do the same thing for the back side.

    -
    step 6 of 7
    +
    Step 6 of 7
    -
    +
    Capture Back Image of the Check > -

    Submit the Deposit

    -
    +

    Submit the Deposit

    +

    Review the images to ensure they are clear, legible, and nothing else (screen frame, instructions, confetti, mouse, etc.) is shown. Confirm and submit them through your bank's app!

    Congratulations! Your money will be in your account as soon as your bank processes the check, usually within 1-2 business days!

    -
    step 7 of 7
    +
    Step 7 of 7
    -
    -
    +
    +
    -

    Review Check for Deposit

    -
    +

    Review Check for Deposit

    +

    There is a problem with your check. First, ask the payer to open the same link while you are both online at the same time, then hit refresh. If the check displays for them but not you, have them re-send you the link so the decryption password matches. If things still do not work, please have them write a new check and contact us with a report at checkard@era.eco.

    -

    +

    Warning: For optimal results, switch to a larger display to follow these instructions properly.

    @@ -200,44 +267,131 @@

    Review Check for Deposit

    going paperless!

    -
    Step 1 of 7
    +
    step 1 of 7
    -
    +
    -

    Endorse the Check

    -
    +

    Endorse the Check

    +

    Type your name onto the back of the check. If your bank requires a "for deposit only" notice, add it onto the 2nd line. For more help, read the CFPB's guide.

    -
    Step 2 of 7
    +
    step 2 of 7
    -
    +
    - + + + + + + + + + + + + + + + -

    Prepare for Check Deposit

    -
    -

    +

    Prepare for Check Deposit

    +
    +

    Warning: Your bank will reject the deposit if any artifact, reflection, mouse, toolbar, or dust interferes with the photos.

    @@ -257,94 +411,94 @@

    Prepare for Check Deposit

    -
    Step 3 of 7
    +
    step 3 of 7
    -
    +
    -

    Open Bank App on Your Phone

    -
    +

    Open Bank App on Your Phone

    +

    Checkard is only compatible with US based banks that support mobile check depositing. If your bank does not have this feature, you can print the check and take it into a branch.

    Open your bank's app on your phone and find a "Check Deposit" option in the main menu or banking services section after logging in. Never share your banking information with us or others.

    -
    Step 4 of 7
    +
    step 4 of 7
    -
    +
    -

    Capture Front Image of the Check

    -
    +

    Capture Front Image of the Check

    +

    - Follow your bank app's instructions and take a photo of the check. Remember: Any artifact, including your screen's frame or case, dust, mouse, these instructions, glare or toolbars MUST be hidden. + Follow your bank app's instructions and take a photo of the check. Remember: Any artifact, including your screen's frame or case, dust, mouse, these instructions, glare or toolbars MUST be hidden.

    Zoom in or out with CMD/CTRL +/-. Tap next step to flip the check.

    -
    Step 5 of 7
    +
    step 5 of 7
    -
    +
    -

    Capture Back Image of the Check

    -
    +

    Capture Back Image of the Check

    +

    Almost done! Now do the same thing for the back side.

    -
    Step 6 of 7
    +
    step 6 of 7
    -
    +
    -

    Submit the Deposit

    -
    +

    Submit the Deposit

    +

    Review the images to ensure they are clear, legible, and nothing else (screen frame, instructions, confetti, mouse, etc.) is shown. Confirm and submit them through your bank's app!

    Congratulations! Your money will be in your account as soon as your bank processes the check, usually within 1-2 business days!

    -
    Step 7 of 7
    +
    step 7 of 7