refactor: create @eq8/mvp-boot

Author: bbartolome

Dockerfile.js

@@ -11,6 +11,6 @@ COPY package.json /opt/mvp/package.json
 RUN npm link --production
 
 COPY ./index.js /opt/mvp/index.js
-COPY ./plugins /opt/mvp/plugins
+COPY ./lib /opt/mvp/lib
 
 CMD mvp --log-level=${LOG_LEVEL}

NOTICE.txt

@@ -2,9 +2,10 @@
 'use strict';
 
 const argv = require('yargs').argv;
+const path = require('path');
 
-// hoist bootstrap function and export
-bootstrap(argv);
+// hoist start function and export
+start(argv);
 
 /**
  * The main function that signals the start of the application
@@ -13,7 +14,7 @@ bootstrap(argv);
  * @param {Object} [args] CLI arguments
  * @returns {undefined}
  */
-async function bootstrap(args) {
+async function start(args) {
 
 	// Extract the settings
 	const { overridesFile } = args || {};
@@ -22,42 +23,54 @@ async function bootstrap(args) {
 		? require(overridesFile)
 		: {};
 
-	const mvp = require('..');
+	const boot = require('@eq8/mvp-boot');
 
-	// Call MVP with a set of options from the CLI which initializes the core components of MVP:
-	// - Logger
-	// - API
-	// - HTTP server
-	const { options, logger, store, server } = await mvp({ overrides });
-	const defaults = {
-		port: 8000,
-		retryInterval: 1000
-	};
-	const { port, storeUri, retryInterval } = options.init(args, defaults);
+	const extensions = path.join(__dirname, '../lib/ext');
+	const define = boot({ overrides, extensions });
 
-	logger.info('initialized', { overrides });
+	define([
+		'-/options/index.js',
+		'-/logger/index.js',
+		'-/store/index.js',
+		'-/server/index.js',
+		'-/ext/controller/index.js'
+	], (options, logger, store, server, controller) => {
+		const defaults = {
+			port: 8000,
+			retryInterval: 1000
+		};
+		const { port, storeUri, retryInterval } = options.init(args, defaults);
 
-	try {
-		const { success } = await server.listen({ port }) || {};
+		logger.info('initialized', { overrides });
 
-		logger.info('server is listening', { port, success });
-	} catch (err) {
-		logger.error('server unable to listen', { port, err });
-		process.exitCode = 1;
-	}
+		listen().then(connect, err => {
+			throw new Error(err);
+		});
 
-	connect();
+		async function listen() {
+			try {
+				server.use(controller.middleware());
 
-	async function connect(callback) {
-		try {
-			const { success } = await store.connect({ storeUri }) || {};
+				const { success } = await server.listen({ port }) || {};
 
-			logger.info('store has connected', { storeUri, success });
+				logger.info('server is listening', { port, success });
+			} catch (err) {
+				logger.error('server unable to listen', { port, err });
+				process.exitCode = 1;
+			}
+		}
+
+		async function connect() {
+			try {
+				const { success } = await store.connect({ storeUri }) || {};
+
+				logger.info('store has connected', { storeUri, success });
 
-			server.setState('ready'); // TODO: replace with connected, ready if db was created
-		} catch (err) {
-			logger.error('store unable to connect', { storeUri, err });
-			setTimeout(connect, retryInterval, callback);
+				server.setState('ready'); // TODO: replace with connected, ready if db was created
+			} catch (err) {
+				logger.error('store unable to connect', { storeUri, err });
+				setTimeout(connect, retryInterval);
+			}
 		}
-	}
+	});
 }

bin/mvp

@@ -7,12 +7,11 @@
     "mvp": "./bin/mvp"
   },
   "scripts": {
-    "install": "npm-license-crawler > ./NOTICE.txt",
     "precommit": "npm run test:lint",
     "prepush": "npm run test:lint && npm run test:unit",
     "start": "nodemon",
     "test": "npm run test:lint && npm run test:unit && npm run test:integration",
-    "test:lint": "eslint --cache --ext .js index.js bin/* plugins",
+    "test:lint": "eslint --cache --ext .js index.js bin/* lib",
     "test:unit": "tape test/test.unit.js | faucet",
     "test:integration": "tape test/test.integration.js | faucet"
   },
@@ -31,16 +30,11 @@
   },
   "homepage": "https://github.com/eq8/mvp#readme",
   "dependencies": {
+    "@eq8/mvp-boot": "git+https://git@github.com/eq8/mvp-boot.git#master",
     "express": "4.15.3",
-    "immutable": "3.8.1",
     "lodash": "4.17.9",
-    "lru-cache": "4.1.2",
     "request": "2.87.0",
-    "requirejs": "2.3.5",
-    "rethinkdb": "2.3.3",
-    "semver": "5.5.0",
     "url-parse": "1.4.1",
-    "winston": "3.0.0",
     "yargs": "12.0.1"
   },
   "devDependencies": {
@@ -49,7 +43,6 @@
     "faucet": "0.0.1",
     "husky": "0.14.3",
     "nodemon": "1.18.3",
-    "npm-license-crawler": "0.1.9",
     "tape": "4.9.1"
   },
   "nodemonConfig": {