Problem with "Other"

[danielruss]

When the code was changed for in-survey accessibility enhancements (#436) The code to hand the "others" was changed.

originally:

 [...divElement.querySelectorAll("label input,label textarea")].forEach(inputElement => {
      let radioCB = document.getElementById(inputElement.closest('label').htmlFor) 

RadioCB is the input[type="radio"] or input[type="checkbox"] associated with the other input box.

This was changed to

let radioCB = document.getElementById(inputElement.id)
which is the type box.

This is why the results are screwing up when the "other" is selected.

quest/replace2.js

Lines 1036 to 1037 in ec22434

	[...divElement.querySelectorAll("label input,label textarea")].forEach(inputElement => {
	let radioCB = document.getElementById(inputElement.id)

[anthonypetersen]

@danielruss - thanks for highlighting that change! switching the one line back appears to resolve everything, Joe has an additional test he is going to run for VoiceOver

[anthonypetersen]

related to episphere/questionnaire#370

[JoeArmani]

This bug was addressed in #444, and the revert/fix is included in release v1.1.7.