-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Description
Due to the changes made in #99, #144 and #149, some BaseEstimator child classes are now outdated and either need to be updated or removed (e.g. the polybin3d classes are now handled by the jaxpower backend of BaseEstimator), as they will now crash.
The most obvious ones being: CountsInCells, MinkowskiFunctionals, MinimumSpanningTree, and all the polybin3d classes
While doing this work, we could also consider improving some inheritance properties of the child classes (such as defining a common logger in BaseEstimator with logging.getLogger(self.__class__.__name__)) and avoiding writing by hand class properties that can be obtained trough calls to the class attributes
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels